Bug 397922 - Right to left support incomplete
Summary: Right to left support incomplete
Status: RESOLVED FIXED
Alias: None
Product: lokalize
Classification: Applications
Component: editor (other bugs)
Version First Reported In: 2.0
Platform: Ubuntu Linux
: NOR critical
Target Milestone: ---
Assignee: Nick Shaforostoff
URL:
Keywords: rtl
Depends on:
Blocks:
 
Reported: 2018-08-27 10:49 UTC by Hamidreza Jafari
Modified: 2021-09-20 18:50 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/ktextwidgets/commit/e76a94f35bb69bedb6afe5c9abc38e8a7dfb9994
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Hamidreza Jafari 2018-08-27 10:49:42 UTC 
Hello,

Translating English to Persian (RTL) is buggy. Ctrl+arrow jumps opposite as usual. Ctrl+delete does Ctrl+backspace.
Comment 1 Yaron Shahrabani 2020-11-07 13:02:40 UTC 
Tested with Hebrew, still happens.
Comment 2 Bug Janitor Service 2021-09-19 03:52:16 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/ktextwidgets/-/merge_requests/16
Comment 3 Yaron Shahrabani 2021-09-19 04:37:05 UTC 
Partially but the original reporter will have to confirm, I think RTL still has many bugs.
Comment 4 Safa Alfulaij 2021-09-19 04:47:04 UTC 
Then, can someone list all the issues you have with RTL?
Comment 5 Safa Alfulaij 2021-09-20 18:50:21 UTC 
Git commit e76a94f35bb69bedb6afe5c9abc38e8a7dfb9994 by Safa AlFulaij.
Committed on 20/09/2021 at 18:50.
Pushed by safaalfulaij into branch 'master'.

Handle RTL text selection the same way as Qt


Ctrl+del was deleting the word on the right regardless of text direction. Changed to be logical-based.

Ctrl+left, Ctrl+right was moving the cursor based on the logical direction, which doesn't really make since since you are saying "left", "right". Changed to be visual-based.

The logic now is the same as Qt.

M  +9    -3    src/widgets/ktextedit.cpp

https://invent.kde.org/frameworks/ktextwidgets/commit/e76a94f35bb69bedb6afe5c9abc38e8a7dfb9994