Bug 397887 - Can't delete default Activity ?
Summary: Can't delete default Activity ?
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.13.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-26 13:16 UTC by isalliswell
Modified: 2019-01-10 16:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.8


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description isalliswell 2018-08-26 13:16:36 UTC
We have a default activity listed under 
                        Desktop Behaviour -> Activities
there is a delete icon beside that activity, on clicking it prompts for confirmation to delete the default activity but even if we select "Yes", it doesn't delete the default activity.

The issue is if it is not supposed to delete the default activity then what's the point of having the delete icon there?


Note:Excuse me if my bug reports sounds silly.I am tired of reading/listening that KDE settings are cluttered and trying to report some bugs from the perspective of a new user.Thank you for your time!
Comment 1 Nate Graham 2019-01-06 06:56:27 UTC
Git commit eafb35076fa3e88951712a7f5bed2a33ccb7b4e0 by Nate Graham.
Committed on 06/01/2019 at 06:55.
Pushed by ngraham into branch 'Plasma/5.12'.

[Activities KCM] Disable delete button when there's only one activity
FIXED-IN; 5.12.8

M  +3    -0    kcms/activities/qml/activitiesTab/ActivitiesView.qml

https://commits.kde.org/plasma-desktop/eafb35076fa3e88951712a7f5bed2a33ccb7b4e0
Comment 2 isalliswell 2019-01-09 08:24:24 UTC
Hi Nate,

It seems like it is not merged in 5.14.5 even though it is mentioned in the 5.14.5 change log.Can you confirm?
Comment 3 Nate Graham 2019-01-09 15:32:36 UTC
Weird. Are the buttons now vertically centered within their list items? Or is that missing too?
Comment 4 isalliswell 2019-01-10 14:24:11 UTC
Sorry, not sure which buttons are you talking about.Please see the below screenshot:
https://i.imgur.com/NVF9HTJ.png
Comment 5 Nate Graham 2019-01-10 14:40:18 UTC
As far as I can tell, the commit made it into the tag, so it should be present in the 5.14.5 release. Can you restart the computer and look again?
Comment 6 isalliswell 2019-01-10 14:52:25 UTC
Already restarted,no gain.Can you specify the file path to check the code changes?
Comment 7 Nate Graham 2019-01-10 15:56:00 UTC
Find the path with find /usr | grep -i "ActivitiesView.qml"

In that file, search for "Disable the button when there's only one activity"
Comment 8 isalliswell 2019-01-10 16:04:13 UTC
Well the code is there.

https://i.imgur.com/1hQVzhq.png

What might be the issue then,packaging in Neon?
Comment 9 Nate Graham 2019-01-10 16:07:25 UTC
Weird! It does feel like a packaging issue, yeah.
Comment 10 David Edmundson 2019-01-10 16:14:22 UTC
It can't be a packaging issue if the code is there on his machine.
Comment 11 David Edmundson 2019-01-10 16:19:55 UTC
activitiesList is not defined
Comment 12 David Edmundson 2019-01-10 16:30:05 UTC
Git commit ae8483efa40f4d47b3143405f0757a7edc126984 by David Edmundson.
Committed on 10/01/2019 at 16:29.
Pushed by davidedmundson into branch 'Plasma/5.12'.

[Activities KCM] Fix patch to not delete default activity

Summary:
Patch referenced an id which didn't exist

Test Plan:
Had one activity, was disabled
Had two, both were enabled

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18159

M  +1    -0    kcms/activities/qml/activitiesTab/ActivitiesView.qml

https://commits.kde.org/plasma-desktop/ae8483efa40f4d47b3143405f0757a7edc126984