Bug 397851 - Disabled entries in context menu are unreadable when blur and transparency effects are active
Summary: Disabled entries in context menu are unreadable when blur and transparency ef...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.16.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-08-24 21:52 UTC by Patrick Silva
Modified: 2021-06-26 04:18 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
kate (125.82 KB, image/png)
2018-08-24 21:52 UTC, Patrick Silva
Details
okular (69.73 KB, image/png)
2018-08-24 21:53 UTC, Patrick Silva
Details
opaque vs semi-transparent text (81.14 KB, image/png)
2020-07-29 03:26 UTC, Lucas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-08-24 21:52:57 UTC
Created attachment 114591 [details]
kate

My screenshots show the context menus of kate and okular when blur and transparency effects are enabled.
Comment 1 Patrick Silva 2018-08-24 21:53:21 UTC
Created attachment 114592 [details]
okular
Comment 2 Alex Nemeth 2018-08-25 10:54:21 UTC
Nate how should we solve this?
Comment 3 Nate Graham 2018-08-25 19:08:22 UTC
I was hoping you had some idea. :)
Comment 4 Alex Nemeth 2018-08-25 19:10:10 UTC
(In reply to Nate Graham from comment #3)
> I was hoping you had some idea. :)

no no
I was asking from a design standpoint
do we make the text lighter? or give it a background? what else?
Comment 5 Nate Graham 2018-08-27 04:26:46 UTC
Hah, I see! Seems like there is a general conceptual issue here:

When using Breeze light and the transparent+blurred element is over a dark element, the menu background darkens significantly, which reduces the readability of dark text (i.e. active menu items).

When using Breeze dark and the transparent+blurred element is over a light element, the background lightens significantly, which reduces the readability of light text (e.g. inactive menu items).


Here's an idea: When the transparent element's inherent color is significantly different from the color of whatever's beneath it, we could brighten or darken the result to make it better match the transparent element's original color.
Comment 6 Filip Fila 2019-07-09 13:17:29 UTC
I don't know what the code is like right now but we could tint disabled entries instead of making them transparent.
Comment 7 Lucas 2020-07-29 03:26:59 UTC
Created attachment 130469 [details]
opaque vs semi-transparent text
Comment 8 Lucas 2020-07-29 03:27:15 UTC
The best approach here is to add transparency to the disabled text as well (it is currently not transparent, just greyed out).
In the screenshot, the accelerator text has 60% opacity, while the left text is 100% opaque and nearly invisible.
Comment 9 Bug Janitor Service 2020-08-21 00:17:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/22
Comment 10 Nate Graham 2021-06-26 04:18:54 UTC
This was fixed by that. :