Bug 397845 - Choose player within player widget is not properly themed
Summary: Choose player within player widget is not properly themed
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (other bugs)
Version First Reported In: 5.13.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-24 16:38 UTC by RaitaroH
Modified: 2018-09-06 12:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Breeze dark theme (555.69 KB, image/png)
2018-08-24 16:38 UTC, RaitaroH
Details
Breeze light theme (557.08 KB, image/png)
2018-08-24 16:39 UTC, RaitaroH
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RaitaroH 2018-08-24 16:38:36 UTC
Created attachment 114584 [details]
Breeze dark theme

When you open the player widget you can change if the player will be chosen automatically or not. With a dark theme, breeze or otherwise, the text becomes white but the background of the dropdown is still white. 

If I remember correctly this was fixed within the advanced section of audio, that is device profiles.
Comment 1 RaitaroH 2018-08-24 16:39:00 UTC
Created attachment 114585 [details]
Breeze light theme
Comment 2 Marco Martin 2018-09-06 12:07:59 UTC
Git commit 51d863ce2438f132add9a469807d38947ad7fca8 by Marco Martin.
Committed on 06/09/2018 at 12:07.
Pushed by mart into branch 'master'.

port to PlasmaComponents3

Summary:
the pieces of old components we couldn't control, like the combobox menu
didn't react to palette change

Test Plan: applet still works and looks identical, combo popup changes color dinamically

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15165

M  +24   -23   applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

https://commits.kde.org/plasma-workspace/51d863ce2438f132add9a469807d38947ad7fca8