Bug 397716 - Cannot subscribe to adblock filter lists
Summary: Cannot subscribe to adblock filter lists
Status: RESOLVED WORKSFORME
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (show other bugs)
Version: unspecified
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-21 19:27 UTC by starcastle550
Modified: 2020-11-24 04:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 3.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description starcastle550 2018-08-21 19:27:32 UTC
When I hit the "subscribe" button for any list on filterlists.com (in this case, the "anti-adblock-killer" / "AakList"), falkon just gives this popup message:

Could not find any application or handler for abp:subscribe?location=https%3A%2F%2Fraw.githubusercontent.com%2Freek%2Fanti-adblock-killer%2Fmaster%2Fanti-adblock-killer-filters.txt&title=AakList (Anti-Adblock Killer)

Trying to add them manually doesn't work either, but it doesn't explain why, and that way is too time consuming, anyhow...

I'm surprised this bug isn't already even mentioned here already...
Comment 1 David Rosca 2018-12-24 20:01:39 UTC
Git commit 47f2a1697ca81224822b89f152ecf4b7a16a2b69 by David Rosca.
Committed on 24/12/2018 at 19:39.
Pushed by drosca into branch 'master'.

AdBlockManager: Parse also invalid abp: urls

Some sites (like filterlists.com) serves invalid abp urls:

    abp:subscribe?location=https%3A%2F%2Ffoo.com&title=AakList

Make sure the "amp;title" key will be parsed as title.
FIXED-IN: 3.1.0

M  +2    -2    src/lib/adblock/adblockmanager.cpp

https://commits.kde.org/falkon/47f2a1697ca81224822b89f152ecf4b7a16a2b69
Comment 2 starcastle550 2019-03-06 21:41:53 UTC
Despite being able to subscribe to lists from filterlists.org, I still get "error: cannot load subscription" for most of them....
Comment 3 Justin Zobel 2020-10-25 05:43:44 UTC
(In reply to starcastle550 from comment #2)
> Despite being able to subscribe to lists from filterlists.org, I still get
> "error: cannot load subscription" for most of them....

Is this in Falkon 3.1.0?
Comment 4 Bug Janitor Service 2020-11-09 04:33:52 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2020-11-24 04:34:15 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!