Bug 397684 - Enabling "Enhanced Media Controls" breaks Home Assistant
Summary: Enabling "Enhanced Media Controls" breaks Home Assistant
Status: RESOLVED WORKSFORME
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: Firefox (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-20 19:56 UTC by Leo Verto
Modified: 2019-08-21 19:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Verto 2018-08-20 19:56:45 UTC 
When "Enhanced Media Controls" is enabled, Home Assistant fails to load and throws "TypeError: this._meta.byKey is not a function".

Now I realize this may not sound like an issue on your side but interestingly enough, the LastPass extension seems to have caused the exact same problem in the past: https://github.com/home-assistant/home-assistant-polymer/issues/448 and per the referenced issues, also caused problems for other projects using web components (https://github.com/webcomponents/webcomponentsjs/issues/819, https://github.com/appreciated/vaadin-app-layout/issues/98).

Now if this is really caused by the same addon behaviour then the plasma browser integration could very well also break other websites using similar polymer/webcomponent code but I haven't gotten a chance to check it yet.
Comment 1 Kai Uwe Broulik 2018-08-21 10:01:39 UTC 
Issues like these are why we disabled it by default
Comment 2 Kai Uwe Broulik 2018-08-21 10:04:57 UTC 
Do you have a test install of "Home Assistant" where I can try to debug the problem?
Comment 3 Kai Uwe Broulik 2018-08-21 10:06:38 UTC 
I'll try with https://www.home-assistant.io/demo/
Comment 4 Kai Uwe Broulik 2018-08-21 10:08:57 UTC 
Can't reproduce in Chrome or Chromium, both with my and an empty profile (just p-b-i, no blockers). The demo site loads just fine.
Comment 5 Kai Uwe Broulik 2019-08-21 19:11:58 UTC 
Home assistant supposedly ported away from the framework that broke with this. Also, the enhanced media controls won't tamper with the website DOM anymore in the upcoming release. Closing this now.