Bug 397586 - OSD to configure multi-monitor mode is not centered on the screen under Wayland
Summary: OSD to configure multi-monitor mode is not centered on the screen under Wayland
Status: RESOLVED FIXED
Alias: None
Product: KScreen
Classification: Plasma
Component: common (show other bugs)
Version: 5.18.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Frederik Gladhorn
URL:
Keywords: wayland
Depends on:
Blocks:
 
Reported: 2018-08-18 14:32 UTC by Patrick Silva
Modified: 2020-04-22 16:19 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
screenshot (1.09 MB, image/png)
2018-08-18 14:32 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-08-18 14:32:07 UTC
Created attachment 114477 [details]
screenshot

See the screenshot taken on neon dev unstable.
Comment 1 Alexander Mentyu 2018-08-19 11:04:51 UTC
Can reproduce

Distribution: KDE neon Developer Edition
Kernel: 4.15.0-29-generic
Plasma: 5.13.80
Apps: 18.11.70
Qt: 5.11.1
Frameworks: 5.48.0
Graphics:
Card-1: Intel 
driver: i915 v: kernel bus ID: 00:02.0 chip ID: 8086:5917 
Card-2: NVIDIA GM108M [GeForce 940MX] 
driver: nouveau v: kernel bus ID: 01:00.0 chip ID: 10de:134d 
Display: wayland server: X.Org 1.19.6 
driver: modesetting,nouveau 
unloaded: fbdev,vesa alternate: nvidia compositor: kwin wayland 
resolution: 1920x1080~57Hz 
OpenGL: renderer: Mesa DRI Intel UHD Graphics 620 (Kabylake GT2) 
v:4.5 Mesa 18.0.5 compat-v:3.0 direct render: Yes
Comment 2 Alexander Mentyu 2018-08-19 12:31:37 UTC
On Netrunner Rolling distribution i noticed different behavior - OSD is appearing in top center of the screen, than it dissappears and and appears in about 1/3 of screen height - looks like on same height that volume and brightnes OSDs have and also in the center, that after that it disappears again and appears a little bit higher in the center and stays there. It's all happen in a fraction of second 

Kernel: 4.17.17-1-MANJARO
Plasma: 5.13.4
Apps: 18.04.3
Qt: 5.11.1
Frameworks: 5.48.0
Wayland: 1.15.0
Graphics:
Card-1: Intel UHD Graphics 620 driver: i915 v: kernel bus ID: 00:02.0 
chip ID: 8086:5917 
Card-2: NVIDIA GM108M [GeForce 940MX] driver: N/A bus ID: 01:00.0
chip ID: 10de:134d 
Display: wayland server: X.Org 1.20.1 driver: intel compositor: kwin wayland 
resolution: 1920x1080~57Hz 
OpenGL: renderer: Mesa DRI Intel UHD Graphics 620 (Kabylake GT2)
v: 4.5 Mesa 18.1.6 
compat-v: 3.0 direct render: Yes
Comment 3 Frederik Gladhorn 2018-08-20 07:59:53 UTC
This got broken, due to the addition of keyboard handling. The type of the popup window changed, so that it can take keyboard focus and react accordingly.
Comment 4 Nate Graham 2018-08-20 12:00:52 UTC
...Which most likely makes this a duplicate of Bug 386304.

*** This bug has been marked as a duplicate of bug 386304 ***
Comment 5 Frederik Gladhorn 2018-08-20 15:48:12 UTC
I don't think this is a duplicate, since it touches a different module than KWin. Unless there is some magic solution, we need to apply the fix in several repos.
Comment 6 Nate Graham 2018-08-20 16:57:07 UTC
Let's test. :) Is the issue fixed for you if you apply https://phabricator.kde.org/D13084 to KWin? If that fixes it, it's a dupe; if not, you're right, and we can un-dupe it.
Comment 7 Patrick Silva 2018-09-04 11:40:54 UTC
bug 386304 is already fixed on neon dev unstable but the bug reported here persists.
Comment 8 Nate Graham 2018-09-05 03:29:18 UTC
Guess it wasn't a dupe. :) Thanks for checking.
Comment 9 Benjamin Port 2020-04-22 15:03:34 UTC
Git commit b3b45721ee17828d5711ff88d5f1777b65c2834a by Benjamin Port.
Committed on 22/04/2020 at 15:03.
Pushed by bport into branch 'master'.

fix(kded): center action OSD on wayland

Summary:
Currently on Wayland the Action OSD is not centered on the screen.

On Wayland we will center it on m_output (laptop, with fallback to primary and
then to first one).

X behavior is not changed.

Reviewers: romangg, davidedmundson

Reviewed By: romangg, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28916

M  +9    -2    kded/osd.cpp
M  +6    -0    kded/qml/OsdSelector.qml

https://commits.kde.org/kscreen/b3b45721ee17828d5711ff88d5f1777b65c2834a