Bug 397558 - Guides ignore change of canvas shape
Summary: Guides ignore change of canvas shape
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-17 18:28 UTC by Storm Engineer
Modified: 2019-09-11 20:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Storm Engineer 2018-08-17 18:28:00 UTC
If the canvas shape changes via rescaling image, rotating or resizing canvas, the guides will not follow along, and simply stay at the same absolute position they were before. When resizing canvas guides will ignore the offset as well.

Expected behavior: Guides should keep their position relative to the canvas through resize/rotation.
Comment 1 Jaime Torres 2018-09-13 17:44:05 UTC
Even better, if there is a way they can be snapped to a proportion offset of the canvas (so they move automatically when the canvas is changed) or a fixed offset, both options are useful.
Related to https://bugs.kde.org/show_bug.cgi?id=314878
Comment 2 vanyossi 2019-08-13 14:35:29 UTC
Hi, I need some more information to get this right.

Guides can be adjusted relative to the image size on "image size", but should it work on canvas resize? Since the coordinates to expand can be adjusted in 9 cuadrants, how the guides are supposed to adjusst?

On canvas resize
- Divide the canvas in 2 vertcal and 2 horizonal regions, on canvas resize adjust the guides relative to the nearest border.
- Do nothing: canvas resize should not mingle with guides

On canvas rotation.
We have not implemented diagonal guides so adjusting for rotation would not be possible.
Comment 3 Jaime Torres 2019-08-13 16:26:59 UTC
Hi, in krita 4.2.5 the guides already rotate with the rotating canvas.
In my opinion:

If the block guides option is selected, they don't change in any resize (image or canvas) or image rotation.
If the block guides option is not selected, they change according to canvas resize following their previous position in the rule. For example, assuming the canvas is not rotated, if an horizontal guide was in 100 of 1000 in the rule and the canvas is resized, no matter at what side, to 2000 in the rule, the guide should be in 200.

Is this is useful? I don't know.
Comment 4 wolthera 2019-09-10 20:10:07 UTC
Ivan, I think this one is fixed in master because of dmitry's transforming assistants fix(which also touched guides). Can you check and close?
Comment 5 vanyossi 2019-09-11 20:55:12 UTC
Indeed Wolthera. Now resizing and rotating image changes guides position accordingly.