Bug 397549 - Searching for tags in Dolphin doesn't always work
Summary: Searching for tags in Dolphin doesn't always work
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-baloo
Classification: Frameworks and Libraries
Component: Tags (show other bugs)
Version: 5.48.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: baloo-bugs-null
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-08-17 11:27 UTC by Michael D
Modified: 2018-12-10 03:44 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2018-08-17 11:27:48 UTC
I have multiple files with the same tag. When I click on the tag in the information pane to search for all files with the same tag, I sometimes only get one result, no results, or the right results. I've double checked that the tag is actually in the xattrs of the file using getfattr -d.

This occurs even after having disabled baloo, removing the index files from ~/.local/share/baloo, and then re-enabling. File content searching is disabled.
Comment 1 Nate Graham 2018-08-21 20:31:51 UTC
Darn, that's a shame.

Nicolas, I think you were recently working on beefing up the reliability of the tags feature?
Comment 2 Stefan Brüns 2018-10-16 18:23:09 UTC
Probably fixed with
https://phabricator.kde.org/D16255

Please check the output of
getfattr -d <filename>
balooshow -x <filename>  ("XAttr Terms:")
Comment 3 Stefan Brüns 2018-10-25 16:11:24 UTC
Git commit 43ab022f35e812b71ab866402c16505aab929529 by Stefan Brüns.
Committed on 25/10/2018 at 16:11.
Pushed by bruns into branch 'master'.

[Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

Summary:
Baloo uses the metadata change time (stat.st_ctime, man 7 inode) to check
for XAttr updates. This field corresponds to
QFileInfo::metadataChangeTime(), while created() returns the first
available of [birthtime, ctime, mtime].

On filesystems supporting birthtime (XFS, BTRFS) some files were
continously reindexed as the BasicIndexingJob stored the ctime, while the
UnindexedFileIterator compared the stored value with the btime. On the
other hand, XAttr changes where not detected when ctime and btime
initially matched, as the btime is fixed.

While at it, document the semantics of the two timestamps.
Related: bug 349615

Test Plan:
1. watch baloo_file with strace -efile during startup
  -> files with btime != ctime are indexed just once
2. add a Tag to a file
  -> file is immediately updated in index, not just after
  baloo_file restart (e.g. session restart)

Reviewers: #baloo, #frameworks, poboiko, ngraham, lbeltrame

Reviewed By: lbeltrame

Subscribers: lbeltrame, kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D16255

M  +11   -3    src/engine/documenttimedb.h
M  +1    -1    src/file/basicindexingjob.cpp
M  +10   -3    src/file/modifiedfileindexer.cpp
M  +10   -1    src/file/unindexedfileiterator.cpp

https://commits.kde.org/baloo/43ab022f35e812b71ab866402c16505aab929529
Comment 4 Andrew Crouthamel 2018-11-10 01:37:57 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2018-11-25 04:46:03 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2018-12-10 03:44:29 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!