Bug 397493 - Duplicate for overwrite function
Summary: Duplicate for overwrite function
Status: RESOLVED FIXED
Alias: None
Product: Skanlite
Classification: Applications
Component: general (show other bugs)
Version: 2.1.0.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Kåre Särs
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2018-08-15 17:57 UTC by Antoni Bella
Modified: 2020-05-01 14:55 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/skanlite/3f02d27dd9cec12f803e297eee62513584fe8ace
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antoni Bella 2018-08-15 17:57:09 UTC 
Every time I have to overwrite a file we show two different dialogues:

Frameworks native (kio5.po):
title:   Overwrite File?
message: The file "baja.png" already exists. Do you wish to overwrite it?

and

Skanlite native (skanlite.cpp:479):
message: Do you want to overwrite "baja.png"?

  Regards
  Toni
Comment 1 Nate Graham 2018-08-21 20:11:14 UTC 
Yeah, we don't need Skanlite to re-implement this feature since it's now built into the KIO Save dialog so everyone gets it for free.
Comment 2 Frederick Yin 2020-04-08 06:56:18 UTC 
I have located and tackled the problem. Now only the overwrite prompt by KIO will show up. Patch: https://phabricator.kde.org/D28672
Comment 3 Nate Graham 2020-05-01 14:55:57 UTC 
Git commit 3f02d27dd9cec12f803e297eee62513584fe8ace by Nate Graham, on behalf of Frederick Yin.
Committed on 01/05/2020 at 14:55.
Pushed by ngraham into branch 'master'.

Remove unnecessary overwrite prompt

Summary: BUG: 397493

Reviewers: sars, #kde_applications, ngraham

Reviewed By: sars, #kde_applications, ngraham

Subscribers: cfeck, ngraham, pino

Differential Revision: https://phabricator.kde.org/D28672

M  +4    -30   src/skanlite.cpp

https://commits.kde.org/skanlite/3f02d27dd9cec12f803e297eee62513584fe8ace