Bug 397446 - Scrolling in the Album, Artist, etc. and Now Playing views is much too fast
Summary: Scrolling in the Album, Artist, etc. and Now Playing views is much too fast
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.2.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-14 12:43 UTC by Michael D
Modified: 2018-10-01 07:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2018-08-14 12:43:22 UTC
Scrolling the Album, etc. view is really fast with my Elan touchpad. I'm using wayland and libinput and haven't bothered to check X with synaptics. It's so fast I have to drag the scroll bar to make it usable. I've not encountered any other qt application with this problem.
Comment 1 Michael D 2018-08-14 12:45:26 UTC
This might be a duplicate of bug 393157 but there is so much noise in there I suggest closing it.
Comment 2 Alexander Mentyu 2018-08-15 18:51:48 UTC
Too fast scrolling also on X

elisa/xenial,now 0.2.1+p16.04+git20180716.1126-0 amd64
Distribution: KDE neon Developer Edition
Kernel: 4.15.0-29-generic
Plasma: 5.13.80
Apps: 18.11.70
Qt: 5.11.1
Frameworks: 5.48.0
Comment 3 Matthieu Gallien 2018-08-16 12:22:09 UTC
Thanks for your report. It seems related to https://bugreports.qt.io/browse/QTBUG-56075 . It seems that some KDE Qml project already have a workaround. I will have a look but I cannot reproduce it with my laptop. Will you be able to test a patch ?
Comment 4 Michael D 2018-08-16 12:40:46 UTC
Thanks for looking into it. Theoretically, I could test a patch, but if that requires doing something to some source code and then compiling it, it's probably out of my league. If it's simpler than that, then I'd be more than happy to test a patch.
Comment 5 Nate Graham 2018-08-21 20:22:03 UTC
The good news is that it's likely simpler if it only requires QML changes; you can just edit the QML files on your system and restart Elisa!

I also recommend closing Bug 393157. It's probably not ever going to be actionable.

A local workaround is be nice, but even better would be an upstream patch of course! :)
Comment 6 Matthieu Gallien 2018-09-26 16:57:46 UTC
I have create this review: https://phabricator.kde.org/D15777 .
I need some help since I cannot reproduce the bug and so cannot test the fix.
I picked a component from Kube that should fix too fast scrolling.
Comment 7 Alexander Mentyu 2018-09-27 20:34:00 UTC
Looks like normal scrolling after patch - both on Wayland and X11

Netrunner Rolling
Plasma: 5.13.5
Apps: 18.08.1
Frameworks: 5.50.0
Qt: 5.11.2
Comment 8 Matthieu Gallien 2018-09-27 20:39:58 UTC
(In reply to Alexander Mentyu from comment #7)
> Looks like normal scrolling after patch - both on Wayland and X11
> 
> Netrunner Rolling
> Plasma: 5.13.5
> Apps: 18.08.1
> Frameworks: 5.50.0
> Qt: 5.11.2

Thanks for your feedback. So, I can consider the solution as working. Is it correct ?
Comment 9 Alexander Mentyu 2018-09-28 11:27:57 UTC
Yes, the scrolling speed looks ok to me.
Comment 10 Matthieu Gallien 2018-09-28 15:52:05 UTC
Git commit 13eb252dc6c3ab7bc4ce972fb7ae87e44af1a450 by Matthieu Gallien.
Committed on 28/09/2018 at 15:51.
Pushed by mgallien into branch '0.3'.

use ScrollHelper component from Kube

Summary:
should help fix scroll for people affected by bug 397446

scrolling by drag no longer works, so I am looking at feedback
(mostly from touch screen users)

Test Plan: none

Reviewers: astippich, januz, ngraham

Differential Revision: https://phabricator.kde.org/D15777

M  +1    -0    src/CMakeLists.txt
M  +6    -0    src/qml/FileBrowserView.qml
M  +6    -0    src/qml/GridBrowserView.qml
M  +6    -0    src/qml/ListBrowserView.qml
M  +6    -0    src/qml/MediaPlayListView.qml
A  +117  -0    src/qml/ScrollHelper.qml     [License: GPL (v2+)]
M  +1    -0    src/resources.qrc

https://commits.kde.org/elisa/13eb252dc6c3ab7bc4ce972fb7ae87e44af1a450
Comment 11 Michael D 2018-10-01 07:38:25 UTC
Thanks very much for the fix. It's working great for me as well in version 3.0.
Comment 12 Matthieu Gallien 2018-10-01 07:51:50 UTC
(In reply to Michael D from comment #11)
> Thanks very much for the fix. It's working great for me as well in version
> 3.0.

Thanks for your report.