Bug 397206 - Kicker: submenus are too wide after opening Recent Documents containing long filename
Summary: Kicker: submenus are too wide after opening Recent Documents containing long ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.13.3
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-06 10:36 UTC by rantovich
Modified: 2018-08-16 13:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Bug behaviour (3.22 MB, image/gif)
2018-08-06 10:36 UTC, rantovich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rantovich 2018-08-06 10:36:43 UTC
Created attachment 114318 [details]
Bug behaviour

Kicker's submenus are too wide when I hover mouse over Recent Documents first and there is long filename in Recent Documents. When I hover mouse over categories first or let submenus disappear and then hover mouse over them, then submenus are reasonably small. Expecting that submenus will dynamically change their size. Looks like submenus somehow inherit width of Recent Documents.

Steps to reproduce:
1. Open any file with long filename (over 50 characters in my case).
2. Open Application Menu and go to Recent Documents. There will be this filename.
3. Move mouse down to app categories. Submenus will be too wide.

See attachment for this behaviour.

OS: Fedora 28
Plasma: 5.13.3
Qt: 5.10.1
Comment 1 Eike Hein 2018-08-06 16:22:29 UTC
Albert, do you want to have a go? IIRC this is a side-effect of your change?
Comment 2 Albert Astals Cid 2018-08-06 19:14:19 UTC
You said you didn't want the width to jump when changing menus, that's what i did. So that would be a "no bug"?
Comment 3 Eike Hein 2018-08-06 20:25:11 UTC
According to the user bug report, a wide menu now raises some floor that it never dips below again. I don't think that's what I requested :). Wasn't it supposed to expand if needed, but stick to the default size when it can?
Comment 4 Albert Astals Cid 2018-08-06 23:59:31 UTC
No, that's not what I understand we agreed. 

I understood you wanted to minimize jumps in width while visiting the menu.

If it did what you are suggesting now it would jump in width continuously when you switch between Recent Documents and Administration.

So what it does is stick to the minimum size for the menus you've visited until now.

If you don't like that and prefer the width to jump for every menu you visit that is fine, it is actually what i wanted but I thought it was clear it was not what you wanted.
Comment 5 Eike Hein 2018-08-07 08:36:15 UTC
Maybe we misunderstood each other somehow (or I misunderstood). Do you have time to write the alternate patch?
Comment 6 Albert Astals Cid 2018-08-07 21:19:49 UTC
(In reply to Eike Hein from comment #5)
> Maybe we misunderstood each other somehow (or I misunderstood). Do you have
> time to write the alternate patch?

I'll make some time during Akademy (next week)
Comment 7 Albert Astals Cid 2018-08-14 14:12:09 UTC
Reviews welcome

https://phabricator.kde.org/D14836
Comment 8 Albert Astals Cid 2018-08-16 13:24:40 UTC
Git commit 5dd480208afc33e526ed25f0478fa424e518366e by Albert Astals Cid.
Committed on 16/08/2018 at 13:24.
Pushed by aacid into branch 'Plasma/5.13'.

Kicker: Reset re-used menu width to default one

Reviewers: hein

Reviewed By: hein

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14836

M  +1    -0    applets/kicker/package/contents/ui/ItemListView.qml

https://commits.kde.org/plasma-desktop/5dd480208afc33e526ed25f0478fa424e518366e