For example, I set Win+M for maximizing the active window. But if there is a taskmanager item at the position [m], it still shows the [m] badge that shouldn't show. What do you think about this ?
(In reply to trmdi from comment #0) > For example, I set Win+M for maximizing the active window. But if there is a > taskmanager item at the position [m], it still shows the [m] badge that > shouldn't show. > > What do you think about this ? cant be done... Latte cant know what shortcuts the user has set for other apps or even for its own applets
(In reply to Michail Vourlakos from comment #1) > (In reply to trmdi from comment #0) > > For example, I set Win+M for maximizing the active window. But if there is a > > taskmanager item at the position [m], it still shows the [m] badge that > > shouldn't show. > > > > What do you think about this ? > > cant be done... > Latte cant know what shortcuts the user has set for other apps or even for > its own applets Wait. Why not? At least you can check from the file `~/.config/kglobalshortcutsrc` (I don't know if there is a better way) [Latte] activate entry 17=,Meta+M,Activate Entry 17 -> not used A new idea: [Latte] activate entry 11=Meta+Z,Meta+Z,Activate Entry 11 -> badge shows "Z" (it means it shows what it gets from the config, not the hardcorded one)
(In reply to trmdi from comment #2) > (In reply to Michail Vourlakos from comment #1) > > (In reply to trmdi from comment #0) > > > For example, I set Win+M for maximizing the active window. But if there is a > > > taskmanager item at the position [m], it still shows the [m] badge that > > > shouldn't show. > > > > > > What do you think about this ? > > > > cant be done... > > Latte cant know what shortcuts the user has set for other apps or even for > > its own applets > > Wait. Why not? At least you can check from the file > `~/.config/kglobalshortcutsrc` (I don't know if there is a better way) > > [Latte] > activate entry 17=,Meta+M,Activate Entry 17 -> not used > > A new idea: > > [Latte] > activate entry 11=Meta+Z,Meta+Z,Activate Entry 11 -> badge shows "Z" (it > means it shows what it gets from the config, not the hardcorded one) sorry too messy...
being too smart automatically it is a lot of a mess for this.. there are many cases that cant be caught... For example there are more issues... what is done if the user alternates the Latte shortcuts from 11-19 to something different.. What Latte is going to show? The appearance for 1-9,0,z,x,c,v,...,> is hardcoded! An approach could be for the user to alter that visual from a stringlist in lattedockrc file e.g.: default: 1,2,3,4,5,6,7,8,9,0,z,x,c,v,b,n,m,<,> user set example1: 1,2,3,4,5,6,7,8,9,0,z,x,c,v,b,n,--,<,> (-- could mean dont show and dont execute) user set example2: 1,2,3,w,e,6,7,8,9,0,a,s,--,f,g,h,j,l
(In reply to Michail Vourlakos from comment #4) > For example there are more issues... what is done if the user alternates the > Latte shortcuts from 11-19 to something different.. > What Latte is going to show? I don't get your point here. Can you give an example for this?
ok... ok... you are right! :) it can be done... on Latte startup that file kglobalshortcutsrc can be accessed and Latte could identify what the user has set! none = no global shortcut has been set Meta+(whatever) = the whatever is the identifier Meta+...+\\ = first occurence of '\' should be removed in order to find the identifier that array afterwards could be accessed from entire Latte in order to show the proper global shortcuts badges!!! @trmdi would you like to give a try? Do you have any programming experience?
(In reply to Michail Vourlakos from comment #6) > ok... ok... > you are right! :) > > it can be done... > > on Latte startup that file kglobalshortcutsrc can be accessed and Latte > could identify what the user has set! > > none = no global shortcut has been set > Meta+(whatever) = the whatever is the identifier > Meta+...+\\ = first occurence of '\' should be removed in order to find the > identifier > > that array afterwards could be accessed from entire Latte in order to show > the proper global shortcuts badges!!! > > @trmdi would you like to give a try? Do you have any programming experience? Sorry. I just have the idea, but know almost nothing about programming. :P
Git commit 9a69323293aa8cd01ead8e92ca1125e4d2a4eabd by Michail Vourlakos. Committed on 03/08/2018 at 23:05. Pushed by mvourlakos into branch 'master'. smarter badges identifier for activation shortcuts --with this commit now Latte is able to identify what are the global shortcuts used for each activation entry and also to not show at all any badge for activation entries that are disabled from the user M +85 -7 app/universalsettings.cpp M +12 -3 app/universalsettings.h M +31 -66 containment/package/contents/ui/applet/AppletItemWrapper.qml M +8 -0 containment/package/contents/ui/main.qml M +2 -0 plasmoid/package/contents/ui/main.qml M +10 -12 plasmoid/package/contents/ui/task/TaskIconItem.qml https://commits.kde.org/latte-dock/9a69323293aa8cd01ead8e92ca1125e4d2a4eabd
(In reply to trmdi from comment #7) > Sorry. I just have the idea, but know almost nothing about programming. :P Ok... have fun with it... :) https://i.imgur.com/quU647l.png I implemented it and for fun I assigned some global shortcuts with greek characters (even though plasma isnt triggerring them) and I disabled also the Meta+X shortcut
Perfectly ! Thanks a lot Michail.
A small idea, can you make the badges case-sensitive ? E.g: shortcut = Win+s -> show "s" (lowercase) shortcut = Win+Shift+S -> display "S" (uppercase) In case, for example, I want to set S for SystemSettings, and s for smplayer.
(In reply to trmdi from comment #11) has Shift -> "S", NO shift -> "s" E.g. My setup: https://i.imgur.com/usF6Twk.png
There are several types of a shortcut: Shift+S, Alt+S, Shift+Alt+S, Meta+S, Meta+Shift+S... So I think the best test is: Meta+[a-z] -> lowercase, non-(Meta+[a-z]) -> uppercase that will remind the user about his shortcut, he will remember that he uses a Meta+[a-z] or a non-(Meta+[a-z]) for that item. + non-(Meta+[a-z]) includes Meta+Shift+[a-z]
(In reply to trmdi from comment #12) > (In reply to trmdi from comment #11) > > has Shift -> "S", NO shift -> "s" > > E.g. My setup: https://i.imgur.com/usF6Twk.png let me recap if I understood correctly, you propose the following: OneModifier+Letter (lower case) -> e.g. Meta+A or Ctrl+A = 'a' TwoAndMoreModifiers+Letter (upper case) -> e.g. Meta+Shift+A or Meta+Ctrl+A = 'A' is that correct?
(In reply to trmdi from comment #13) > There are several types of a shortcut: Shift+S, Alt+S, Shift+Alt+S, Meta+S, > Meta+Shift+S... > > So I think the best test is: Meta+[a-z] -> lowercase, non-(Meta+[a-z]) -> > uppercase > > that will remind the user about his shortcut, he will remember that he uses > a Meta+[a-z] or a non-(Meta+[a-z]) for that item. > > + non-(Meta+[a-z]) includes Meta+Shift+[a-z] I mean this. Only Meta+A-> show "a" Ctrl+A, Shift+A, Meta+Shift+A... -> show "A" This allows users set "Meta+A" and "Ctrl+A/Shift+A/..." and the badges remind him about it. See my example above. Of course this only makes the badges more useful without any side problem.
What happens if: Meta+A and Ctrl+A both show "A" ? The users will not able to remmember that they are the different shortcuts.
(In reply to trmdi from comment #16) > What happens if: Meta+A and Ctrl+A both show "A" ? > The users will not able to remmember that they are the different shortcuts. I can understand what you are trying to explain but what are the criteria for this? I prefer simple explanations.. Q: A user asks why some of my activation badges are lowerCase and some upperCase? A1: All Meta+... are lowerCase and the reset upperCase. Meta+Y = 'y' because it uses Meta A2: All defaults are lowerCase (e.g. Meta+z, Meta+x, ...) and all the reset upperCase. Meta+Y = 'Y' which is not at default ones I would propose A2
Second thought A1 might be simpler... so lets go for A1
(In reply to Michail Vourlakos from comment #18) > Second thought A1 might be simpler... so lets go for A1 You mean Meta+A ="a" and Meta+Shift+A = "A"? (Only meta+a shows "a") That is what I want.
Git commit 8062a766057b84a76ea59f2b92f55156ea410c4b by Michail Vourlakos. Committed on 04/08/2018 at 10:42. Pushed by mvourlakos into branch 'master'. improve activation badges visual indicators --when an activation shortcut follows Meta+"Character" scheme it is shown lowerCase and at all other cases it is shown upperCase M +9 -2 app/universalsettings.cpp https://commits.kde.org/latte-dock/8062a766057b84a76ea59f2b92f55156ea410c4b
Tested the new commit. Works perfectly. Again, thank you very much, Michail !