Bug 397058 - Updates page toolbar lost its bottom line
Summary: Updates page toolbar lost its bottom line
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-01 14:10 UTC by Nate Graham
Modified: 2018-08-02 14:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.14.0


Attachments
No bottom line on toolbar (184.79 KB, image/png)
2018-08-01 14:10 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-08-01 14:10:42 UTC
Created attachment 114255 [details]
No bottom line on toolbar

With git master, on the Updates page there's no longer a gray line separating the bottom of the toolbar from its content area. See attached screenshot.
Comment 1 Nate Graham 2018-08-01 14:30:01 UTC
I notice that the white bar below the toolbar does have the line, though. But it has a different background color and looks weird butted up against the toolbar with no separating line.

If this bar is considered to be a part of the toolbar header, it either needs to have the same background color, or if its background color is supposed to be different, it needs a line separating it from the rest of the toolbar.
Comment 2 Aleix Pol 2018-08-02 13:38:31 UTC
Git commit af0c90831d814db9c5a76a6df00cc02ac6a61eb2 by Aleix Pol.
Committed on 02/08/2018 at 13:37.
Pushed by apol into branch 'master'.

Unify header and toolbar background color

M  +4    -2    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/af0c90831d814db9c5a76a6df00cc02ac6a61eb2