Bug 397038 - Latte setting window is a bit wide after some recent commit
Summary: Latte setting window is a bit wide after some recent commit
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Unmaintained
Component: application (other bugs)
Version First Reported In: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-01 03:47 UTC by trmdi
Modified: 2018-08-03 23:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trmdi 2018-08-01 03:47:39 UTC
Please see the pictures below:

Before: https://i.imgur.com/XYYuAGO.png
After: https://i.imgur.com/ZybH9H9.png
Comment 1 Michail Vourlakos 2018-08-01 08:18:54 UTC
yep, I wanted a way the ratio I see in my computer (settings width to settings height) to be the same across different computers and different screen resolutions. 

So you dont like it? :)
Comment 2 trmdi 2018-08-01 09:24:14 UTC
(In reply to Michail Vourlakos from comment #1)
> yep, I wanted a way the ratio I see in my computer (settings width to
> settings height) to be the same across different computers and different
> screen resolutions. 
> 
> So you dont like it? :)

Yes, you can see in this picture: https://i.imgur.com/L7GArbY.png
the blue area is a waste, the red dropdown is too wide.
Comment 3 Michail Vourlakos 2018-08-01 10:10:17 UTC
(In reply to trmdi from comment #0)
> Before: https://i.imgur.com/XYYuAGO.png

sorry but this is awful, no symmetry at all... 

only thing I could accept is if the height could become smaller in order for the width also to follow. I will work on it but the symmetry in very important.
Comment 4 Michail Vourlakos 2018-08-01 10:16:06 UTC
btw both before and after have an issue... the bottom buttons shouldnt be placed there, they should be placed exactly at the bottom edge of the of the settings window...

this is how settings window should look: https://imgur.com/iYS49ca
Comment 5 trmdi 2018-08-01 10:26:24 UTC
(In reply to Michail Vourlakos from comment #4)
> btw both before and after have an issue... the bottom buttons shouldnt be
> placed there, they should be placed exactly at the bottom edge of the of the
> settings window...
> 
> this is how settings window should look: https://imgur.com/iYS49ca

Yours looks ok. I just want mine looks like that.
Yes, mine is too high. It need some adjustment.
Comment 6 Michail Vourlakos 2018-08-01 14:35:55 UTC
Git commit a5a4b876dee8268083f7e186f084e6662ea5bddb by Michail Vourlakos.
Committed on 01/08/2018 at 14:31.
Pushed by mvourlakos into branch 'master'.

improve dock settings windows geometry calculation

--the dock settings window calculations should not look
different between different font settings/geometries/screens.
One way to overcome that issue is by using the font.height to
calculate the settings height, that is 37chars for now and
the width to be calculated in accordance with that height. There
are some down limits for both, height shouldnt overcome screens
height and shouldnt go under 400px  and the width can not be
less than 200px

M  +6    -8    shell/package/contents/configuration/LatteDockConfiguration.qml

https://commits.kde.org/latte-dock/a5a4b876dee8268083f7e186f084e6662ea5bddb
Comment 7 Michail Vourlakos 2018-08-01 14:36:55 UTC
Can you please show me how your settings window looks with last commit?
Comment 8 trmdi 2018-08-01 16:06:55 UTC
(In reply to Michail Vourlakos from comment #7)
> Can you please show me how your settings window looks with last commit?

The difference is very slight: https://i.imgur.com/86Vjcd5.png
I think the width (and maybe the height) is still a bit too wide.
Comment 9 Michail Vourlakos 2018-08-01 16:12:25 UTC
(In reply to trmdi from comment #8)
> (In reply to Michail Vourlakos from comment #7)
> > Can you please show me how your settings window looks with last commit?
> 
> The difference is very slight: https://i.imgur.com/86Vjcd5.png
> I think the width (and maybe the height) is still a bit too wide.

something with your font probably or your font settings... it must have some big paddings around it... what font are you using?
Comment 10 Michail Vourlakos 2018-08-01 16:15:16 UTC
2. Can you show me a screenshot of Behavior Tab? the Tasks Tab has space in it by the short texts in the checkboxes...


from your screenshot I can see also two issues resolved: 
a. the settings window touches exactly the dock edge
b. the action buttons (add/remove/close) are exactly where they should be
Comment 11 trmdi 2018-08-01 16:21:34 UTC
1. My font config: https://i.imgur.com/PntrhnC.png
2. A screenshot of Behavior Tab: https://i.imgur.com/NeuPAcE.png
Comment 12 Michail Vourlakos 2018-08-02 16:01:54 UTC
(In reply to trmdi from comment #11)
> 1. My font config: https://i.imgur.com/PntrhnC.png
> 2. A screenshot of Behavior Tab: https://i.imgur.com/NeuPAcE.png

before playing more with it, I would propose to play also with your font settings, we might be able to improve them, if you dont like them of course you can change them afterwards... :)

1. Find the correct DPI setting for your screen, you can use https://www.sven.de/dpi/ for this. You set your screen resolution and how big is your screen at inches e.g. 15.6 and that provides a PPI value which is the DPI we are searching
2. Go to your Font settings and:
  A. Set everything to font size 12
  B. Enable "Use anti-aliasing"
  C. Disable "Exclude range from anti-aliasing"
  D. Choose "Vertical RGB"
  E. Choose "Slight"
  F. Enable Force Fonts DPI
  G. Write the PPI you found at previous site for the DPI record at integer value e.g. 109.27 = 109  etc etc.
Comment 13 Michail Vourlakos 2018-08-02 16:02:46 UTC
3. You need to restart an application in order to check out the new font settings how good are they... These settings provide me also fantastic anti-aliasing for LibreOffice case
Comment 14 Michail Vourlakos 2018-08-02 16:28:52 UTC
Git commit 04b2d84abb23a8998a40fa5ec9b351fd5e42ae07 by Michail Vourlakos.
Committed on 02/08/2018 at 16:28.
Pushed by mvourlakos into branch 'master'.

decrease a bit the settings height

M  +1    -1    shell/package/contents/configuration/LatteDockConfiguration.qml

https://commits.kde.org/latte-dock/04b2d84abb23a8998a40fa5ec9b351fd5e42ae07
Comment 15 trmdi 2018-08-02 17:14:23 UTC
(In reply to Michail Vourlakos from comment #12)

My screen: 1366x768, 14inch -> PPI: 111
The font size 12 is too big for my screen, so I let it be 8. Look more ugly than before: https://i.imgur.com/JZybaGB.png :p
(Using the commit 0472d... already)
Comment 16 trmdi 2018-08-02 17:32:33 UTC
(In reply to trmdi from comment #15)
> (In reply to Michail Vourlakos from comment #12)
> 
> My screen: 1366x768, 14inch -> PPI: 111
> The font size 12 is too big for my screen, so I let it be 8. Look more ugly
> than before: https://i.imgur.com/JZybaGB.png :p
> (Using the commit 0472d... already)

Font size 10, PPI 111, replace your 36 with 30, it looks better: https://i.imgur.com/Fp5fxbf.jpg
Comment 17 trmdi 2018-08-02 17:33:58 UTC
(In reply to trmdi from comment #16)
> Font size 10, PPI 111, replace your 36 with 30, it looks better:
> https://i.imgur.com/Fp5fxbf.jpg

Sorry, the default PPI (maybe 96)
Comment 18 Michail Vourlakos 2018-08-02 22:53:03 UTC
Git commit fef362a52f628fa308eb77f109e9ba1c7ca57a21 by Michail Vourlakos.
Committed on 02/08/2018 at 22:52.
Pushed by mvourlakos into branch 'master'.

a way for the user to change settings window size

--user can now use Meta+ScrollWheel in order to
increase/decrease the size of the dock settings
window according to its preference

M  +8    -0    containment/package/contents/config/main.xml
M  +1    -1    shell/package/contents/configuration/AppearanceConfig.qml
M  +1    -1    shell/package/contents/configuration/BehaviorConfig.qml
M  +72   -8    shell/package/contents/configuration/LatteDockConfiguration.qml
M  +1    -1    shell/package/contents/configuration/TasksConfig.qml
M  +3    -3    shell/package/contents/configuration/TweaksConfig.qml

https://commits.kde.org/latte-dock/fef362a52f628fa308eb77f109e9ba1c7ca57a21
Comment 19 Michail Vourlakos 2018-08-02 22:55:04 UTC
(In reply to trmdi from comment #16)
> (In reply to trmdi from comment #15)
> > (In reply to Michail Vourlakos from comment #12)
> > 
> > My screen: 1366x768, 14inch -> PPI: 111
> > The font size 12 is too big for my screen, so I let it be 8. Look more ugly
> > than before: https://i.imgur.com/JZybaGB.png :p
> > (Using the commit 0472d... already)
> 
> Font size 10, PPI 111, replace your 36 with 30, it looks better:
> https://i.imgur.com/Fp5fxbf.jpg

ok, so user settings etc. can influence that so I can not thin an optimal solution for everyone. This commit gives the user the freedom to scale the size of the dock settings window. In order to do that you can use Meta+ScrollWheel at the free areas of the dock settings window for increasing/decreasing the settings window size scale.
Comment 20 Michail Vourlakos 2018-08-03 23:06:05 UTC
Git commit 1b47a3749ed8e728b2efdf8d53ebbedbaa94be44 by Michail Vourlakos.
Committed on 03/08/2018 at 23:05.
Pushed by mvourlakos into branch 'master'.

add size boundaries for dock settings window

--improve the new added code for user set settings
window size by specific boundaries in which it can
be set and not exit them

M  +18   -7    shell/package/contents/configuration/LatteDockConfiguration.qml

https://commits.kde.org/latte-dock/1b47a3749ed8e728b2efdf8d53ebbedbaa94be44