Bug 396983 - ActionToolbar not working as intended in InlineMessage
Summary: ActionToolbar not working as intended in InlineMessage
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-30 12:50 UTC by Fabian
Modified: 2018-08-02 11:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Code to reproduce the problem (890 bytes, text/x-qml)
2018-07-30 12:50 UTC, Fabian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian 2018-07-30 12:50:01 UTC
Created attachment 114221 [details]
Code to reproduce the problem

If you add to many actions to an InlineMessage, the ActionToolbar is overflowing the message widgets instead of collapsing the actions into an overflow menu.
Comment 1 Marco Martin 2018-08-02 11:26:47 UTC
(In reply to Fabian from comment #0)
> Created attachment 114221 [details]
> Code to reproduce the problem
> 
> If you add to many actions to an InlineMessage, the ActionToolbar is
> overflowing the message widgets instead of collapsing the actions into an
> overflow menu.

looking there is indeed an issue..
tough, also the test code contains an error which makes it behave way worse when it should (also, pay attention about it in your other examples for the hig):
if an item is in a layout (RowLayout, ColumnLayout, GridLayout) it should never, ever define its own width or height: it will ensure things are resizing very glitchy.

at most it can have implicitWidth/height, or in the layout attached, Layout.minimumWidth preferred/maximum hints
Comment 2 Marco Martin 2018-08-02 11:36:43 UTC
Git commit 555d6a5cfb792ceb43eac05276e5b78256549112 by Marco Martin.
Committed on 02/08/2018 at 11:36.
Pushed by mart into branch 'master'.

better management of the size

M  +3    -0    src/controls/ActionToolBar.qml
M  +13   -13   src/controls/InlineMessage.qml

https://commits.kde.org/kirigami/555d6a5cfb792ceb43eac05276e5b78256549112