Bug 396906 - compile tests failure on mips32-linux: broken inline asm in tests on mips32-linux
Summary: compile tests failure on mips32-linux: broken inline asm in tests on mips32-l...
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: helgrind (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hongxu Jia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 13:37 UTC by Hongxu Jia
Modified: 2018-09-04 21:28 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
fix broken inline asm in tests on mips32-linux (1.84 KB, patch)
2018-07-27 13:40 UTC, Hongxu Jia
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hongxu Jia 2018-07-27 13:37:09 UTC
While build tests(`make check') with gcc 8.1.0 on mips32-linux,
there is a failure
[snip]
|mips-wrsmllib32-linux-gcc  -meb -mabi=32 -mhard-float -march=mips32
-c -o tc08_hbl2-tc08_hbl2.o `test -f 'tc08_hbl2.c' || echo '../../../
valgrind-3.13.0/helgrind/tests/'`tc08_hbl2.c
|/tmp/cc37aJxQ.s: Assembler messages:
|/tmp/cc37aJxQ.s:275: Error: symbol `L1xyzzy1main' is already defined
|Makefile:1323: recipe for target 'tc08_hbl2-tc08_hbl2.o' failed
[snip]
Comment 1 Hongxu Jia 2018-07-27 13:40:42 UTC
Created attachment 114162 [details]
fix broken inline asm in tests on mips32-linux

Remove the duplicated L1xyzzy1main, and use local symbol to replace.
http://tigcc.ticalc.org/doc/gnuasm.html#SEC46
Comment 2 Dimitrije Nikolic 2018-09-04 15:42:05 UTC
There are no regressions after applying this patch on mips32r2 and mips64r2.
This change look reasonable and acceptable.
Comment 3 Petar Jovanovic 2018-09-04 21:28:20 UTC
Committed.
Thank you for the patch.