Bug 396901 - Updated online quotes from a binary package are not transferred to the current settings.
Summary: Updated online quotes from a binary package are not transferred to the curren...
Status: REPORTED
Alias: None
Product: kmymoney
Classification: Applications
Component: importer (show other bugs)
Version: 4.8.2
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 10:54 UTC by Ralf Habacker
Modified: 2019-01-28 11:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of online quote editor located in alkima (126.81 KB, image/jpeg)
2018-07-30 15:11 UTC, Ralf Habacker
Details
kmymoney screenshot (64.77 KB, image/png)
2018-11-13 19:59 UTC, Ralf Habacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2018-07-27 10:54:52 UTC
Changing any regex of an online quote in the kmymoney source, which is included in an updated binary package will not be transferred to the current settings. Settings->Online quotes still shows the old settings.
Comment 1 Thomas Baumgart 2018-07-29 05:14:32 UTC
Note: this is by design. The reason was that I don't want to override any user changes. Once we can detect if there is user modification of an entry provided by a binary then we can think about replacing the setting by the version found in the new binary if it is still unchanged and don't replace it if it was modified by the user.
Comment 2 Jack 2018-07-29 22:24:42 UTC
Better yet, is there any reasonable way to allow updating of the online sources without updating the software?  

Should this bug be changed to a wishlist:
1) If installing a new version of KMM includes any changes to the existing online sources, allow the user the option to a) ignore the udpates, b) replace any sources that have changed, or c) add changed sources with a new name.  In all cases, any new sources should be added.  If any sources have been deleted, the user should have the option of retaining or deleting them.

2) Provide an online source for online sources, so the above options become available through a menu choice (or plugin config dialog?).  Perhaps the online source data can be isolated to a single file within the program source tree, and also made available for access in a similar way we get ofx direct connect source info.
Comment 3 Ralf Habacker 2018-07-30 15:11:45 UTC
Created attachment 114223 [details]
screenshot of online quote editor located in alkima

(In reply to Jack from comment #2)
> Better yet, is there any reasonable way to allow updating of the online
> sources without updating the software?
For alkimia an editor is under construction, with which online offers of an installation of financial applications like KMyMoney, Skrooge or others, can be checked, modified or downloaded from the KDE store (see screenshot).

The plan is to design an api for finance applications (based on WebPriceQuote and friends) in the 'alk' namespace e.g AlkOnlineQuote to be able to deal with all use cases applications like KMyMoney requires in this area.
Comment 4 Jack 2018-11-11 17:27:42 UTC
Has there been any progress on this?  It might be a good reason not to incorporate libalkimia directly into the KMM code base, as has been proposed.  (See https://phabricator.kde.org/D14522)
Comment 5 Ralf Habacker 2018-11-13 17:12:21 UTC
Yes, recent state is located at https://cgit.kde.org/alkimia.git/log/?h=work/397112-alkonlinequotes
Comment 6 Ralf Habacker 2018-11-13 19:59:11 UTC
Created attachment 116290 [details]
kmymoney screenshot

The kmymoney 4.8 counterpart branch is https://cgit.kde.org/kmymoney.git/log/?h=4.8-alkimia-onlinequote. 

With these branches you are able to fetch a GHNS online source in the online quotes settings dialogs 

As you can see with https://cgit.kde.org/kmymoney.git/commit/?h=4.8-alkimia-onlinequote&id=a06b403b1bdb0acf46146d6ecd5e2b75bdff0913 the required changes are

1. setup AlkOnlineQuotesProfileManager
2. rename WebPriceQuote with AlkOnlineQuote and similar for other related classes

Open stuff:
1 FinanceQuoteProcess related - I do not have a test case for this yet - any hints are welcome
2. I was currently not able to test Tools->prices and Tools->Update stock and currency prices because of missing test cases

The mentioned kmymoney branch is intended for 4.8, a 5.x related will follow. The mentioned alkimia branch is buildable out of the box for 4.8 and 5.x/master.

We need to release alkimia first before the kmymoney related changes could be applied
Comment 7 Jack 2018-11-13 20:23:10 UTC
I've installed libalkimia from it's git master, but will wait for a 5.x version to test.  I can test updating stock prices.  (I tried to get Finance::Quote to work a long time ago, and never did succeed.)
Comment 8 Ralf Habacker 2018-11-18 10:12:06 UTC
(In reply to Jack from comment #7)
> I've installed libalkimia from it's git master, but will wait for a 5.x
> version to test.  I can test updating stock prices.  (I tried to get
> Finance::Quote to work a long time ago, and never did succeed.)

You are suggesting to remove this support ?
Comment 9 Jack 2018-11-18 17:31:59 UTC
I am not requesting or suggesting removal of anything.  When we started with all the problems with online quotes (started when Yahoo stopped being easy to use) I thought Finance::Quote might be useful, but was unable to get it to work  for me.  At some point I'll try again - I agree it is good to have an alternate approach.

What I meant was that I would wait to test per your Comment 6 that a 5.x related (patch?) will follow.  I can't easily test with 4.x since I no longer have any 4.8 version.  If it's important, I suppose I can dig in my backup kmy files for one that was never used with 5.x.
Comment 10 Ralf Habacker 2018-11-18 18:06:38 UTC
> At some point I'll try again - I agree it is good to have an alternate approach
This is what I want to know.

> What I meant was that I would wait to test per your Comment 6 that a 5.x related (patch?) will follow. 
I guess you didn't read the note in comment 6:  
> The mentioned alkimia branch is buildable out of the box for 4.8 and 5.x/master. 

For qt5 you need to install knewstuff-devel and specify -DBUILD_QT4=OFF at cmake command line.  

In the provided standalone application alkonlinequoteeditor you are able to check GHNS support.

BTW: The branch has been provided at review request https://phabricator.kde.org/D16973
Comment 11 Jack 2018-11-18 18:30:09 UTC
I seem to have misunderstood something.  
I did build libalkimia from git-head, but now see I need to checkout the work branch.
Also, I was waiting for a kmymoney branch based on 5.0.  Aside from trying the standalone alkonlinequoteeditor, I'd like to be able to test against KMM 5, since I haven't been able to get any online quotes to work for me for a few months.
Comment 12 Ralf Habacker 2018-11-18 18:46:04 UTC
>Also, I was waiting for a kmymoney branch based on 5.0.
This is in preparation and will coming soon.
Comment 13 Ralf Habacker 2018-11-18 18:49:11 UTC
(In reply to Ralf Habacker from comment #12)
> >Also, I was waiting for a kmymoney branch based on 5.0.
> This is in preparation and will coming soon. With this patch online quote support will be factored out of kmymoney into alkimia, not duplicated to avoid having whole kmymoney as dependency for the provided plasma widget.