Bug 396882 - Freecell: Can move from foundation with double click
Summary: Freecell: Can move from foundation with double click
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: general (show other bugs)
Version: 3.6
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-26 14:56 UTC by xanclic
Modified: 2018-08-05 16:24 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/kpat/49ef224f1c8e15a3583820aa2a2826a5e64de599
Version Fixed In:

Attachments
Potential fix (575 bytes, patch)
2018-07-26 18:56 UTC, Parker Coates 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description xanclic 2018-07-26 14:56:50 UTC 
As bug 36582 explains, recovering a card from the foundation should not be possible, and indeed it is not possible by dragging.  But it is possible to move a card from the foundation to one of the cells by double clicking or right clicking, which it probably should not be.
Comment 1 Shlomi Fish 2018-07-26 17:52:42 UTC 
@xancli(In reply to xanclic from comment #0)
> As bug 36582 explains, recovering a card from the foundation should not be
> possible, and indeed it is not possible by dragging.  But it is possible to
> move a card from the foundation to one of the cells by double clicking or
> right clicking, which it probably should not be.

Thanks for the report! I'll try to investigate.
Comment 2 Parker Coates 2018-07-26 18:56:13 UTC 
Created attachment 114153 [details]
Potential fix

I no longer have a kde-games development enviroment set up, so I can't actually test that this compiles and works, but I believe the fix should be as simple as this.
Comment 3 Shlomi Fish 2018-07-27 17:34:33 UTC 
(In reply to Parker Coates from comment #2)
> Created attachment 114153 [details]
> Potential fix
> 
> I no longer have a kde-games development enviroment set up, so I can't
> actually test that this compiles and works, but I believe the fix should be
> as simple as this.

I tested this patch and it seems to fix the problem. Thanks! Also see https://github.com/shlomif/kpat/tree/fixes .
Comment 4 Albert Astals Cid 2018-07-27 20:16:50 UTC 
Why are you now developing in a for instead of upstream?
Comment 5 Albert Astals Cid 2018-07-27 20:16:58 UTC 
s/for/fork
Comment 6 Shlomi Fish 2018-07-27 21:35:29 UTC 
(In reply to Albert Astals Cid from comment #4)
> Why are you now developing in a for instead of upstream?

I don't know if I still have a git push bit to the kde.org repositories.
Comment 7 Albert Astals Cid 2018-07-28 09:35:11 UTC 
Yes you do.

You can check in https://websvn.kde.org/trunk/kde-common/accounts?view=markup
Comment 8 Shlomi Fish 2018-07-28 09:59:35 UTC 
(In reply to Albert Astals Cid from comment #7)
> Yes you do.
> 
> You can check in https://websvn.kde.org/trunk/kde-common/accounts?view=markup

I see - thanks!
Comment 9 Albert Astals Cid 2018-08-05 16:24:32 UTC 
Git commit 49ef224f1c8e15a3583820aa2a2826a5e64de599 by Albert Astals Cid, on behalf of Parker Coates.
Committed on 05/08/2018 at 16:24.
Pushed by aacid into branch 'Applications/18.08'.

Freecell: Don't allow moving out of foundation

M  +2    -2    freecell.cpp

https://commits.kde.org/kpat/49ef224f1c8e15a3583820aa2a2826a5e64de599