Bug 396848 - Hold Frames not working correctly
Summary: Hold Frames not working correctly
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Unclassified
Component: Animation (show other bugs)
Version: 4.1.1
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-25 14:20 UTC by Bollebib
Modified: 2018-09-07 14:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2018-07-25 14:20:59 UTC
https://www.youtube.com/watch?v=JY_dCMX1dkA&feature=youtu.be


THere is data loss as instead of adding 1 hold to each frame it removes some frames
Comment 1 Dmitry Kazakov 2018-08-13 14:17:31 UTC
Git commit d939200e712b60fef6f36b895f494bf922335840 by Dmitry Kazakov.
Committed on 13/08/2018 at 14:16.
Pushed by dkazakov into branch 'master'.

Fix a problem of Insert Hold Frames action

We should also "offset" empty cell to make sure the expanding
works correctly.

M  +5    -1    plugins/dockers/animation/kis_time_based_item_model.cpp
M  +3    -1    plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/d939200e712b60fef6f36b895f494bf922335840
Comment 2 Halla Rempt 2018-09-07 14:16:03 UTC
Git commit 6067ffa2732977654630bff39396ca84fe46b179 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 07/09/2018 at 12:36.
Pushed by rempt into branch 'krita/4.1'.

Fix a problem of Insert Hold Frames action

We should also "offset" empty cell to make sure the expanding
works correctly.

M  +5    -1    plugins/dockers/animation/kis_time_based_item_model.cpp
M  +3    -1    plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/6067ffa2732977654630bff39396ca84fe46b179