Bug 396833 - "Missing Backends" section sometimes shows actually installed backends
Summary: "Missing Backends" section sometimes shows actually installed backends
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.13.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-25 02:03 UTC by john
Modified: 2018-09-24 16:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of issue (55.25 KB, image/png)
2018-07-25 02:03 UTC, john
Details

Note You need to log in before you can comment on or make changes to this bug.
Description john 2018-07-25 02:03:24 UTC
Created attachment 114104 [details]
screenshot of issue

There are a few issues on the settings page of Discover.

#1 Each subheading (Flatpak, OpenSUSE Tumbleweed (default), and Missing Backends) has too little left margin

#2 "Missing Backends" should be renamed to "Backends", especially when said backends are insalled
Comment 1 Nate Graham 2018-07-25 21:52:31 UTC
One issue per bug report please. See https://community.kde.org/Get_Involved/Bug_Reporting#One_issue_per_bug_report

I'll submit a patch to fix #1, so let's use this to track #2. This is the second report I've seen of this issue, so I think it's real.
Comment 2 Nate Graham 2018-07-25 23:35:20 UTC
Git commit 3cd95b4a4f4d80826d50dbdd2cc4b2ef783cf54e by Nathaniel Graham.
Committed on 25/07/2018 at 23:15.
Pushed by ngraham into branch 'master'.

Increase backend header text's left margin

Summary:
Give the backend name a bit more room so it doesn't look so cramped on the left side. Even though this makes the left edge of the text no longer align with the checkboxes, somehow it looks better overall to me.

Test Plan:
Before:
{F6139953}

After:
{F6139955}

Reviewers: apol, #discover_software_store, #vdg

Reviewed By: apol, #discover_software_store

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14385

M  +1    -0    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/3cd95b4a4f4d80826d50dbdd2cc4b2ef783cf54e
Comment 3 john 2018-07-27 00:02:39 UTC
(In reply to Nate Graham from comment #1)
> One issue per bug report please. See
> https://community.kde.org/Get_Involved/Bug_Reporting#One_issue_per_bug_report
> 
> I'll submit a patch to fix #1, so let's use this to track #2. This is the
> second report I've seen of this issue, so I think it's real.

Sorry about that. I added the second one without thinking :)

Thanks for the fast patch!
Comment 4 Andrew Crouthamel 2018-09-22 03:01:55 UTC
I can confirm this on Manjaro. I installed the flatpak and packagekit backends, and they both list under "Missing Backends".

KDE Plasma Version: 5.13.5
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.1
Comment 5 Aleix Pol 2018-09-24 16:12:38 UTC
Git commit 36e90a76d984e813448c75ad3f4fb9d0b14be002 by Aleix Pol.
Committed on 24/09/2018 at 16:11.
Pushed by apol into branch 'Plasma/5.14'.

Make sure we only show uninstalled backends

M  +1    -0    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/36e90a76d984e813448c75ad3f4fb9d0b14be002