Bug 396726 - regressions for tabbar in master
Summary: regressions for tabbar in master
Status: RESOLVED WORKSFORME
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: master
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: tcanabrava
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2018-07-21 12:42 UTC by Martin Sandsmark
Modified: 2020-12-05 04:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Sandsmark 2018-07-21 12:42:55 UTC
posting these here as well as on the diff in phabricator, so they can be tracked independently, or in case someone discovers more.

«konsole --hide-tabbar» and «konsole --show-tabbar» don't work anymore.

the menu for selecting the profile when opening a new tab is gone, and the new tab button is "broken" (too small and not aligned properly).

«put new tab after current tab» seems to be broken

«expand individual tab width to full window» option in settings -> configure konsole -> tabbar is broken.

a function was removed from the dbus api.

a broken connect() leads to warnings whenever opening a new window: «QObject::connect: No such signal Konsole::TabbedViewContainer::destroyed(TabbedViewContainer*)»

lastly navigationmethod doesn't seem to be propagated when creating new containers, which I think might affect the kpart? haven't researched this, though.
Comment 1 Martin Sandsmark 2018-07-21 12:43:40 UTC
fwiw, here's the referenced diff: https://phabricator.kde.org/D13882
Comment 2 Christoph Feck 2018-07-21 12:52:03 UTC
Please report issues independently, so they can be addressed one by one, unless it is intended to revert the commit.

I have added some tickets alreay, please check the component list.

> the menu for selecting the profile when opening a new tab is gone

Bug 396648.

> «put new tab after current tab» seems to be broken

Bug 396701.
Comment 3 Andreas Hartmetz 2018-07-26 22:16:34 UTC
Dropping into an existing Konsole window doesn't add the tab but creates another window: bug 396891
Comment 4 tcanabrava 2018-07-27 07:01:18 UTC
Most of those are fixed already.
Any rework brings new bugs so I'm not worried and I'm activelly trying to fix the ones that are open
Comment 5 Justin Zobel 2020-11-05 05:17:23 UTC
(In reply to Martin Sandsmark from comment #0)
> posting these here as well as on the diff in phabricator, so they can be
> tracked independently, or in case someone discovers more.
> 
> «konsole --hide-tabbar» and «konsole --show-tabbar» don't work anymore.
> 
> the menu for selecting the profile when opening a new tab is gone, and the
> new tab button is "broken" (too small and not aligned properly).
> 
> «put new tab after current tab» seems to be broken
> 
> «expand individual tab width to full window» option in settings -> configure
> konsole -> tabbar is broken.

I can confirm these all work on konsole from git master, can you please confirm and resolve if this bug can now be closed.
Comment 6 Bug Janitor Service 2020-11-20 04:33:46 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2020-12-05 04:34:08 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!