Bug 396652 - In the Manage User Actions dialog: the tab order is not the expected one
Summary: In the Manage User Actions dialog: the tab order is not the expected one
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.7.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-18 22:21 UTC by Toni Asensi Esteve
Modified: 2018-07-31 04:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Asensi Esteve 2018-07-18 22:21:20 UTC
In the Manage User Actions dialog: the tab order is not the expected one using the Tab key to move between elements.

Thanks!
Comment 1 Toni Asensi Esteve 2018-07-29 11:06:49 UTC
It was recently solved, there is more information in:
    https://phabricator.kde.org/D14230
    https://commits.kde.org/krusader/7980ba68014ca901cb90691c9a89e477583b789f
Comment 2 Nikita Melnichenko 2018-07-30 04:19:15 UTC
I wonder why it's not closed automatically by your commit...
Something wrong with the hooks?
Comment 3 Toni Asensi Esteve 2018-07-30 06:48:53 UTC
> I wonder why it's not closed automatically by your commit...
> Something wrong with the hooks?

Nobody marked the bug as "confirmed" and so it was still "unconfirmed", perhaps this was the reason :-? ; we can try next time :-)
Comment 4 Nikita Melnichenko 2018-07-31 04:48:06 UTC
Git commit 0c38cfab14964a0ffd74d8f3f3610cbcc8aaa88e by Nikita Melnichenko, on behalf of Toni Asensi Esteve.
Committed on 31/07/2018 at 04:47.
Pushed by melnichenko into branch 'stable'.

Correct the tab order in the Manage User Actions dialog

Note: Trying to move elements (and their labels) in the ui file is difficult and makes difficult to compare versions later. So the "Edit > Edit Tab Order" option of Qt Creator was used to edit the tab order, which is much easier, although in order to achieve that, the process adds a tabstops section at the end of the ui file. That tabstops section is much, much simpler to maintain (using Qt Creator or any text editor), and comparing versions is much saner.

FIXED: [ 396652 ] In the Manage User Actions dialog: the tab order is not the expected one

Differential Revision: https://phabricator.kde.org/D14230

(cherry picked from commit 7980ba68014ca901cb90691c9a89e477583b789f)

M  +42   -1    krusader/ActionMan/actionproperty.ui

https://commits.kde.org/krusader/0c38cfab14964a0ffd74d8f3f3610cbcc8aaa88e