Bug 396612 - HourHand's shadow missing
Summary: HourHand's shadow missing
Alias: None
Product: plasmashell
Classification: Plasma
Component: Analog Clock (show other bugs)
Version: 5.12.5
Platform: openSUSE Linux
: NOR minor
Target Milestone: 1.0
Assignee: Bhushan Shah
Depends on:
Reported: 2018-07-17 18:12 UTC by Andrew Solovtsov
Modified: 2019-01-18 15:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0
Sentry Crash Report:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Solovtsov 2018-07-17 18:12:41 UTC
Little error in ui/analogclock.qml:
elementId: "HourHandShdow"

should be:

elementId: "HourHandShadow"

After correction, the shadow appears
Comment 1 Nate Graham 2018-07-17 18:57:44 UTC
Thanks for noticing this! Would you like to submit a patch? It's easy and fast! Here's the documentation:

Comment 2 David Edmundson 2018-07-17 18:58:11 UTC
You're right about the typo, but it doesn't seem that trivial. The shadow shadow appears all offset (on the default breeze theme at least)
Comment 3 Nate Graham 2019-01-16 16:43:57 UTC
Git commit d755013c74217cc63da8db5fffa08e6525f7be7a by Nate Graham.
Committed on 16/01/2019 at 16:43.
Pushed by ngraham into branch 'master'.

Make the clock svg's shadows more logically correct and visually appropriate

This patch gives the clock's hour hand a shadow for the spindle too, since the shadow model we're using should logically have the spindle casting a shadow.

It also also increases the height of the minute hand shadow since its current length is short enough that it sometimes doesn't connect to anything.

Test Plan:
Before: {F6551256}

After: {F6551257}

There are no visual changes whatsoever because the hour hand shadow is not currently displayed (See D17751 for background)

Reviewers: #vdg, #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18288

M  +-    --    src/desktoptheme/breeze/widgets/clock.svgz

Comment 4 Shubham 2019-01-18 09:34:20 UTC
Git commit 975df8f8930cec858215ca4a87be93f28db29afd by Shubham Jangra.
Committed on 18/01/2019 at 09:34.
Pushed by shubham into branch 'master'.

Add shadow to Hour's hand

Depends on D18288
Hour hand did not had shadow.
Now it has.

Test Plan: Add new analog clock widget from "Add widget" on right click context menu

Reviewers: mart, hein, #vdg, ngraham, davidedmundson

Reviewed By: #vdg, ngraham, davidedmundson

Subscribers: ndavis, abetts, ngraham, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17751

M  +3    -3    applets/analog-clock/contents/ui/analogclock.qml