Little error in ui/analogclock.qml: .................... elementId: "HourHandShdow" should be: elementId: "HourHandShadow" After correction, the shadow appears
Thanks for noticing this! Would you like to submit a patch? It's easy and fast! Here's the documentation: https://community.kde.org/Infrastructure/Phabricator#Posting_a_Patch_using_the_website
You're right about the typo, but it doesn't seem that trivial. The shadow shadow appears all offset (on the default breeze theme at least)
Git commit d755013c74217cc63da8db5fffa08e6525f7be7a by Nate Graham. Committed on 16/01/2019 at 16:43. Pushed by ngraham into branch 'master'. Make the clock svg's shadows more logically correct and visually appropriate Summary: This patch gives the clock's hour hand a shadow for the spindle too, since the shadow model we're using should logically have the spindle casting a shadow. It also also increases the height of the minute hand shadow since its current length is short enough that it sometimes doesn't connect to anything. Test Plan: Before: {F6551256} After: {F6551257} There are no visual changes whatsoever because the hour hand shadow is not currently displayed (See D17751 for background) Reviewers: #vdg, #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D18288 M +- -- src/desktoptheme/breeze/widgets/clock.svgz https://commits.kde.org/plasma-framework/d755013c74217cc63da8db5fffa08e6525f7be7a
Git commit 975df8f8930cec858215ca4a87be93f28db29afd by Shubham Jangra. Committed on 18/01/2019 at 09:34. Pushed by shubham into branch 'master'. Add shadow to Hour's hand Summary: Depends on D18288 Hour hand did not had shadow. Now it has. {F6503088} Test Plan: Add new analog clock widget from "Add widget" on right click context menu Reviewers: mart, hein, #vdg, ngraham, davidedmundson Reviewed By: #vdg, ngraham, davidedmundson Subscribers: ndavis, abetts, ngraham, davidedmundson, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D17751 M +3 -3 applets/analog-clock/contents/ui/analogclock.qml https://commits.kde.org/plasma-workspace/975df8f8930cec858215ca4a87be93f28db29afd