Bug 396521 - Page header bars are suddenly too short
Summary: Page header bars are suddenly too short
Status: VERIFIED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: VHI normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-15 02:07 UTC by Nate Graham
Modified: 2018-07-20 03:00 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/kirigami/2e023a079f5626e47d92b19baed23011741e0fd8
Version Fixed In:

Attachments
Header bar is now too short (87.20 KB, image/png)
2018-07-15 02:07 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-07-15 02:07:39 UTC 
Created attachment 113936 [details]
Header bar is now too short

[git master, KDE Neon dev unstable]

A recent change seems to have regressed the height of page header bars. As a result, text and buttons escape from the bounds.

Kirigami gallery is unaffected, so I filed the bug here. :)
Comment 1 Aleix Pol 2018-07-16 13:59:45 UTC 
Discover does nothing specific on the headers on master.
Assigning to Kirigami.

I can reproduce as well.
Comment 2 Marco Martin 2018-07-16 14:19:41 UTC 
Git commit 2e023a079f5626e47d92b19baed23011741e0fd8 by Marco Martin.
Committed on 16/07/2018 at 14:19.
Pushed by mart into branch 'master'.

fix toolbar size

M  +1    -1    src/controls/private/PageRowGlobalToolBarStyleGroup.qml

https://commits.kde.org/kirigami/2e023a079f5626e47d92b19baed23011741e0fd8
Comment 3 Nate Graham 2018-07-20 03:00:55 UTC 
Verified, thanks!