Bug 396490 - No color preview with Eyedropper
Summary: No color preview with Eyedropper
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: 4.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Reinold Rojas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-13 21:37 UTC by Kenneth Evans
Modified: 2021-09-23 09:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Evans 2018-07-13 21:37:31 UTC
I get no preview of what color the Eyedropper is picking.

On the other hand, I do get it when using Alt (or Ctrl) with the Brush.  (I have an additional keybinding for Alt as well as Ctrl, which is not what I am used to.)  The preview is a small square box when using Alt and serves the purpose.  There is nothing with the Eyedropper.
Comment 1 Jaime Torres 2018-09-13 18:07:02 UTC
There is a way to preview the color of the Eyedropper:
Zoom until the pixels are big enough, even bigger than the tool icon.
Otherwise, there is no key to show the color the Eyedropper is over.

Is the zoom solution enough or a key is also needed?
Comment 2 Kenneth Evans 2018-09-13 20:00:19 UTC
Zooming isn't viable.  You are drawing and want to change the color.  Zooming would completely interfere.  It doesn't need a key.  It needs to show the preview when the eyedropper touches the screen, the same as it does with Ctrl.  All drawing programs work that way.  Without a preview, you don't know if you have picked the right color.
Comment 3 Jaime Torres 2018-09-13 20:25:58 UTC
Confirmed then, it should show the color picked in a small square box.
Comment 4 Kenneth Evans 2018-09-13 20:40:00 UTC
Yes, it does not do that.
Comment 5 Bug Janitor Service 2021-08-25 02:38:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1017
Comment 6 Halla Rempt 2021-09-23 09:42:05 UTC
Git commit beb3b2d5e96b443ec5f28c300397176de29ae841 by Halla Rempt, on behalf of Reinold Rojas.
Committed on 23/09/2021 at 09:41.
Pushed by rempt into branch 'master'.

Enable color sample preview for Color Sample Tool

Add a small square box that shows the current color
and the sampled color when using the Color Sample Tool.
This is similiar functionality to using the
color sample shortcut

M  +73   -3    plugins/tools/basictools/kis_tool_colorsampler.cc
M  +9    -0    plugins/tools/basictools/kis_tool_colorsampler.h

https://invent.kde.org/graphics/krita/commit/beb3b2d5e96b443ec5f28c300397176de29ae841
Comment 7 Halla Rempt 2021-09-23 09:42:13 UTC
Git commit c8b5bfc3c4d65751547a46bb5b8281ad578c5ab6 by Halla Rempt, on behalf of Reinold Rojas.
Committed on 23/09/2021 at 09:41.
Pushed by rempt into branch 'master'.

Make preview rect disappear when moving off canvas

Fixed the preview rectangle lingering on the canvas when
the mouse was moving off screen.

M  +61   -31   plugins/tools/basictools/kis_tool_colorsampler.cc
M  +10   -0    plugins/tools/basictools/kis_tool_colorsampler.h

https://invent.kde.org/graphics/krita/commit/c8b5bfc3c4d65751547a46bb5b8281ad578c5ab6
Comment 8 Halla Rempt 2021-09-23 09:43:19 UTC
Git commit 7d5241248d207f540bd51b63ca3ad63a845384d3 by Halla Rempt, on behalf of Reinold Rojas.
Committed on 23/09/2021 at 09:42.
Pushed by rempt into branch 'krita/5.0'.

Enable color sample preview for Color Sample Tool

Add a small square box that shows the current color
and the sampled color when using the Color Sample Tool.
This is similiar functionality to using the
color sample shortcut
(cherry picked from commit beb3b2d5e96b443ec5f28c300397176de29ae841)

M  +73   -3    plugins/tools/basictools/kis_tool_colorsampler.cc
M  +9    -0    plugins/tools/basictools/kis_tool_colorsampler.h

https://invent.kde.org/graphics/krita/commit/7d5241248d207f540bd51b63ca3ad63a845384d3
Comment 9 Halla Rempt 2021-09-23 09:43:27 UTC
Git commit eacaa74037cd7357b06cc0e17b06eb301b02319c by Halla Rempt, on behalf of Reinold Rojas.
Committed on 23/09/2021 at 09:42.
Pushed by rempt into branch 'krita/5.0'.

Make preview rect disappear when moving off canvas

Fixed the preview rectangle lingering on the canvas when
the mouse was moving off screen.
(cherry picked from commit c8b5bfc3c4d65751547a46bb5b8281ad578c5ab6)

M  +61   -31   plugins/tools/basictools/kis_tool_colorsampler.cc
M  +10   -0    plugins/tools/basictools/kis_tool_colorsampler.h

https://invent.kde.org/graphics/krita/commit/eacaa74037cd7357b06cc0e17b06eb301b02319c