Bug 396483 - Dulling mode of the Smudge Brush engine ignores Overlay Mode
Summary: Dulling mode of the Smudge Brush engine ignores Overlay Mode
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (other bugs)
Version First Reported In: 4.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Eoin O'Neill
URL:
Keywords: investigated, triaged
Depends on:
Blocks:
 
Reported: 2018-07-13 16:19 UTC by Kapyia
Modified: 2018-11-20 08:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kapyia 2018-07-13 16:19:01 UTC
Don't think I can explain it further than the title + video demonstration, sorry :)
Comment 1 Kapyia 2018-07-13 16:21:20 UTC
Video attachment too large, here's a link:
https://drive.google.com/file/d/1S9-qbE6CLmWd2XscJGyJMy8o7d1wABfr/view?usp=sharing
Comment 2 Eoin O'Neill 2018-09-15 21:40:20 UTC
Application Version: Master

Confirmed. Smudge Length "Dulling mode" seems to override any overlay mode behavior, likely a control flow issue.
Comment 3 Eoin O'Neill 2018-10-12 08:12:46 UTC
Git commit d4fbf53155b2e1642aef81bc288f8c8cf5010a93 by Eoin O'Neill.
Committed on 12/10/2018 at 08:10.
Pushed by eoinoneill into branch 'master'.

Fixed bug where smudge brush did not respect 'Overlay Mode' while 'Smudge
Length' mode is set to 'Dulling'.

M  +24   -15   plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M  +2    -1    plugins/paintops/colorsmudge/kis_colorsmudgeop.h

https://commits.kde.org/krita/d4fbf53155b2e1642aef81bc288f8c8cf5010a93
Comment 4 Halla Rempt 2018-11-20 08:48:22 UTC
Git commit 8476d4aa4471bd6beea754a37308ea0e05f9000d by Boudewijn Rempt, on behalf of Eoin O'Neill.
Committed on 20/11/2018 at 08:20.
Pushed by rempt into branch 'krita/4.1'.

Fixed bug where smudge brush did not respect 'Overlay Mode' while 'Smudge
Length' mode is set to 'Dulling'.

M  +24   -15   plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M  +2    -1    plugins/paintops/colorsmudge/kis_colorsmudgeop.h

https://commits.kde.org/krita/8476d4aa4471bd6beea754a37308ea0e05f9000d