Bug 396417 - It is hard to recover size in the global drawer
Summary: It is hard to recover size in the global drawer
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-11 18:00 UTC by Emmanuel Lepage Vallée
Modified: 2018-08-03 10:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emmanuel Lepage Vallée 2018-07-11 18:00:34 UTC
In the global drawer, there is the name of the application in the drawer header.

This is all and well, but when more space is required in the drawer, it is nicer to get rid of it dynamically instead of having a scrollable drawer.

As of recently, getting to disable the header icon and app name is possible, but the space wasn't fully recovered. Also getting a QtQuick.Layout2 based element to take the full height can be made to work, but it definitely doesn't "just works" when you use `Layout.fillHeight: true`.

In both case, you can dark magic around the issues using Voodoo, but the code is ugly and it should not be necessary.

tl;dr: going from having the header to not having the header while using the full drawer height should work and it currently doesn't.
Comment 1 Marco Martin 2018-08-03 10:13:52 UTC
Git commit 007ef1e0c119f5abd0ccebfcfb396038d1983ad8 by Marco Martin.
Committed on 03/08/2018 at 10:12.
Pushed by mart into branch 'master'.

support dynamically adding and removing title

also add in the gallery a function to test it

M  +34   -0    examples/gallerydata/contents/ui/DesktopExampleApp.qml
M  +4    -1    src/controls/GlobalDrawer.qml

https://commits.kde.org/kirigami/007ef1e0c119f5abd0ccebfcfb396038d1983ad8