Bug 396121 - Build failure with libraw-0.19
Summary: Build failure with libraw-0.19
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.1.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL: https://github.com/LibRaw/LibRaw/blob...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 09:22 UTC by Lars Wendler (Polynomial-C)
Modified: 2018-09-04 09:56 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
build.log.xz (152.39 KB, application/x-xz)
2018-07-03 09:24 UTC, Lars Wendler (Polynomial-C)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) 2018-07-03 09:22:48 UTC
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:381:32: error: ‘struct libraw_output_params_t’ has no member named ‘linenoise’
             raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.NRThreshold * 2.11E-5 + 0.00111111;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:382:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfaline’
             raw.imgdata.params.cfaline      = true;
                                ^~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:389:32: error: ‘struct libraw_output_params_t’ has no member named ‘lclean’
             raw.imgdata.params.lclean       = m_parent->m_rawDecodingSettings.NRThreshold     * 5E-5;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:390:32: error: ‘struct libraw_output_params_t’ has no member named ‘cclean’
             raw.imgdata.params.cclean       = m_parent->m_rawDecodingSettings.NRChroThreshold * 5E-5;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:391:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfa_clean’
             raw.imgdata.params.cfa_clean    = true;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:398:32: error: ‘struct libraw_output_params_t’ has no member named ‘linenoise’
             raw.imgdata.params.linenoise    = 0;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:399:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfaline’
             raw.imgdata.params.cfaline      = false;
                                ^~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:400:32: error: ‘struct libraw_output_params_t’ has no member named ‘lclean’
             raw.imgdata.params.lclean       = 0;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:401:32: error: ‘struct libraw_output_params_t’ has no member named ‘cclean’
             raw.imgdata.params.cclean       = 0;
                                ^~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:402:32: error: ‘struct libraw_output_params_t’ has no member named ‘cfa_clean’
             raw.imgdata.params.cfa_clean    = false;
                                ^~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:408:24: error: ‘struct libraw_output_params_t’ has no member named ‘ca_correc’; did you mean ‘exp_correc’?
     raw.imgdata.params.ca_correc  = m_parent->m_rawDecodingSettings.enableCACorrection;
                        ^~~~~~~~~
                        exp_correc
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:409:24: error: ‘struct libraw_output_params_t’ has no member named ‘cared’
     raw.imgdata.params.cared      = m_parent->m_rawDecodingSettings.caMultiplier[0];
                        ^~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:410:24: error: ‘struct libraw_output_params_t’ has no member named ‘cablue’
     raw.imgdata.params.cablue     = m_parent->m_rawDecodingSettings.caMultiplier[1];
                        ^~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:464:24: error: ‘struct libraw_output_params_t’ has no member named ‘eeci_refine’
     raw.imgdata.params.eeci_refine    = m_parent->m_rawDecodingSettings.eeciRefine;
                        ^~~~~~~~~~~
/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:465:24: error: ‘struct libraw_output_params_t’ has no member named ‘es_med_passes’; did you mean ‘med_passes’?
     raw.imgdata.params.es_med_passes  = m_parent->m_rawDecodingSettings.esMedPasses;
                        ^~~~~~~~~~~~~
                        med_passes
make[2]: *** [plugins/impex/raw/CMakeFiles/krita_raw_import.dir/build.make:119: plugins/impex/raw/CMakeFiles/krita_raw_import.dir/3rdparty/libkdcraw/src/kdcraw_p.cpp.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0_pre_build'
make[1]: *** [CMakeFiles/Makefile2:12963: plugins/impex/raw/CMakeFiles/krita_raw_import.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/media-gfx/krita-4.1.0_pre/work/krita-4.1.0_pre_build'
make: *** [Makefile:141: all] Error 2
Comment 1 Lars Wendler (Polynomial-C) 2018-07-03 09:24:02 UTC
Created attachment 113732 [details]
build.log.xz
Comment 2 Lars Wendler (Polynomial-C) 2018-07-03 09:25:19 UTC
Downstream bug report: https://bugs.gentoo.org/659904
Comment 3 Andreas Sturmlechner 2018-07-08 15:03:25 UTC
The reason see $URL (upstream changelog):

> No more built-in support for LibRaw demosaic packs (GPL2/GPL3).
> We're unable to support this (very old code), so we'll be happy to transfer 
> this code to some maintainer who wish to work with it.
Comment 4 Gwyn Ciesla 2018-08-10 14:05:55 UTC
Seeing this failure on Fedora rawhide(29) as well.
Comment 5 Pino Toscano 2018-09-04 06:46:18 UTC
This was fixed recently in master (future krita 4.2) by:
https://commits.kde.org/krita/3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

I guess a backport to 4.1 would be a good idea too, unless krita people plan to release 4.2.0 soon.
Comment 6 Halla Rempt 2018-09-04 09:56:57 UTC
We're planning a 4.1.2 this month.