I believe that the following string in kde-workspace/plasma-discover.pot should be a plural one: #: discover/qml/ApplicationPage.qml:215 #, kde-format msgid "Show all %1 reviews Assuming that '%1' is the number of reviews. Also this one, if it's still part of the code: #: discover/qml/ApplicationPage.qml:231 #, kde-format msgid "Show reviews (%1)..."
There will only ever be a >1 number there. But you're right, it should use i18np() anyway because languages do plurals differently. Here's a patch: https://phabricator.kde.org/D13785
Git commit d70256447042d33ccab047d3f5c9fba0d6f9c8a5 by Nathaniel Graham. Committed on 28/06/2018 at 19:18. Pushed by ngraham into branch 'master'. Use i18np for a plural string Summary: Use `i18np()` even though this string will always be plural in English; other languages are different, so we should use the correct `i18np()` call. Reviewers: #discover_software_store, apol Reviewed By: #discover_software_store, apol Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D13785 M +1 -1 discover/qml/ApplicationPage.qml https://commits.kde.org/discover/d70256447042d33ccab047d3f5c9fba0d6f9c8a5
Cheers.