Bug 395641 - plasma-redshift-control manual mouse wheel control broken with recent redshift version
Summary: plasma-redshift-control manual mouse wheel control broken with recent redshif...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: General (show other bugs)
Version: 5.13.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Kostolný
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-20 08:57 UTC by grmat
Modified: 2019-10-16 17:39 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch to add -P parameter to one-shot redshift call (1.30 KB, patch)
2018-06-20 08:57 UTC, grmat
Details

Note You need to log in before you can comment on or make changes to this bug.
Description grmat 2018-06-20 08:57:09 UTC
Created attachment 113454 [details]
patch to add -P parameter to one-shot redshift call

redshift changed its default behaviour for one-shot changes, long story short: it now requires an additional parameter for the method used in the applet for mouse wheel scrolling or it will mess up the gamma up to a point where the user can't see anything on the screen. People have already opened bug reports on github for this in both, your deprecated(?) applet repo and the upstream repo of redshift.

This trivial patch adds the missing parameter to get the familiar behaviour working for redshift versions since 1.12.

I'm not familiar with KDE contributions and Phabricator, and didn't found a suiting category on bugs.kde.org, I hope this is addressed anyways.
Comment 1 Andreas Sturmlechner 2018-07-07 07:06:36 UTC
Unfortunately, there seems to be no plasma-redshift-control product to correctly assign to. Code contributions are best done via phabricator.kde.org.
Comment 2 Matthias 2018-10-05 20:52:53 UTC
Its still not applied.
Comment 3 Melvin Vermeeren 2019-08-21 20:37:59 UTC
Submitted a patch to Phabricator: https://phabricator.kde.org/D23330
Comment 4 Nate Graham 2019-10-16 17:39:31 UTC
Git commit 898c3a4cfc6c317915f1e664078d8606497c4049 by Nate Graham, on behalf of Melvin Vermeeren.
Committed on 16/10/2019 at 17:39.
Pushed by ngraham into branch 'master'.

Make manual control compatible with redshift >= 1.12

Summary:

Redshift version >= 1.12 requires the -P option to clear the existing gamma ramps for one-shot mode. Without it the screen gets darker and darker until it is impossible to see anything.

Quoting from the redshift 1.12 manual page:

> -O TEMP One-shot manual mode (set color temperature).  Use this with the -P option to clear the existing gamma ramps before applying the new color temperature.
> -P Reset existing gamma ramps before applying new color effect.

Reviewers: martinkostolny, #plasma, mart

Reviewed By: #plasma, mart

Subscribers: mart, ltoscano, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23330

M  +22   -1    package/contents/ui/CompactRepresentation.qml

https://commits.kde.org/plasma-redshift-control/898c3a4cfc6c317915f1e664078d8606497c4049