open some app that is not pinned to the task manager yet right click its entry in the task manager, select "pin" right click the same entry again: context menu shows "pin" (checked) instead "unpin"
It has a checkbox next to it, so this is correct. It's somewhat inconsistent with launchers, though, that use a separate "Unpin" action.
Yeah, we should consistify this.
Here's a patch: https://phabricator.kde.org/D21856
Git commit af9a794695c73e89a7f0958bd7f071d3fec02996 by Nate Graham. Committed on 17/06/2019 at 13:02. Pushed by ngraham into branch 'master'. [Task manager] Use consistent menu items for "pin/unpin" actions Summary: Make the pinning-relatedmenu items consistent by showing separate Pin and Unpin menu items when not using activities. When using activities, it's unavoidable, so we still show a more complicated UI there with checkboxes for the per-activity pinning options. FIXED-IN: 5.17.0 Test Plan: Right-click on pinned launchers, open unpinned tasks, and open pinned tasks - see that all have the correct menu items Do it again with mode than one Activity and see that all is still well Reviewers: #plasma, #vdg, hein Reviewed By: #plasma, hein Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D21856 M +5 -4 applets/taskmanager/package/contents/ui/ContextMenu.qml https://commits.kde.org/plasma-desktop/af9a794695c73e89a7f0958bd7f071d3fec02996