Bug 395555 - konsole commit e1f7107cc breaks -e option
Summary: konsole commit e1f7107cc breaks -e option
Status: VERIFIED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-18 10:46 UTC by Duncan
Modified: 2018-07-01 00:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2018-06-18 10:46:16 UTC
I have a number of scripts that call konsole with the -e option.  After my last update, they broke -- konsole -e no longer executes the given command, it simply gives me the usual command prompt.

A bisect says it's e1f7107cc to blame.  The commit before that still works.
Comment 1 Duncan 2018-06-18 11:11:47 UTC
Confirming it's commit e1f7107cc.  Reverting that on top of current 48448131e gives me a working -e option.

(It's gentoo/kde live-git packages so I can apply a patch by simply dropping it in the appropriate dir and rebuilding, as I did here for the revert, redirecting the output of git show -R, if you need me to test further patches.)
Comment 2 Kurt Hindenburg 2018-06-19 03:07:10 UTC
Thanks for the report - the issue is in the MW:createSession change - if Thomaz or I can't fix in shortly I'll revert this.
Comment 3 tcanabrava 2018-06-19 08:50:26 UTC
I'm on it.
Comment 4 tcanabrava 2018-06-22 09:06:43 UTC
People, I'v tried to fix e1f7107cc for two days without being able to, so let's just revert that, I'll try to came up with another solution for the code duplication in the future.
Kurt, as I'm new to konsole development, should I revert and push or should I add a review?
Comment 5 Kurt Hindenburg 2018-06-22 10:39:46 UTC
I'll just revert thanks
Comment 6 Kurt Hindenburg 2018-06-22 10:44:27 UTC
Git commit 274633a321625cd2790a217c4422c15ed730f00d by Kurt Hindenburg.
Committed on 22/06/2018 at 10:40.
Pushed by hindenburg into branch 'master'.

Revert "Simplify code dealing with creating new sessions."

This reverts commit e1f7107cc0b42113be9b7ea6b4a0f83ce885ba2d.

This broke -e <cmd>.  Since this was just to simpify code, reverting
for now

M  +16   -2    src/MainWindow.cpp
M  +12   -5    src/Part.cpp
M  +43   -12   src/ViewManager.cpp
M  +12   -1    src/ViewManager.h

https://commits.kde.org/konsole/274633a321625cd2790a217c4422c15ed730f00d
Comment 7 Duncan 2018-07-01 00:14:16 UTC
Verified fixed, thanks.