Bug 395525 - Share ratio is in scientific format
Summary: Share ratio is in scientific format
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: 5.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-06-17 13:29 UTC by Darafei Praliaskouski
Modified: 2018-08-28 19:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
1533 ratio (8.69 KB, image/png)
2018-06-17 13:29 UTC, Darafei Praliaskouski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darafei Praliaskouski 2018-06-17 13:29:15 UTC
Created attachment 113389 [details]
1533 ratio

on Info page of torrent share ratio is in scientific format. Expected to have 1533,90 as without e-notation.
Comment 1 Santiago Munoz 2018-07-12 09:18:00 UTC
I submitted a Phabricator patch for this:

https://phabricator.kde.org/D14070

Cheers!
Comment 2 Andrius Štikonas 2018-07-28 20:14:22 UTC
Git commit 8e40c371fa3982dec38688030d8733429ab5a8a2 by Andrius Štikonas, on behalf of Zdeněk Novák.
Committed on 28/07/2018 at 20:13.
Pushed by stikonas into branch 'master'.

Formatting torrent ratio as floating point number - no scientific notation

'g' format uses exponential notation when numbers are too big or too small,
'f' keeps numbers in 0.00 format all the time.

Differential revision: https://phabricator.kde.org/D13971

M  +4    -4    ktorrent/trayicon.cpp
M  +1    -1    plugins/infowidget/peerviewmodel.cpp
M  +1    -1    plugins/infowidget/statustab.cpp

https://commits.kde.org/ktorrent/8e40c371fa3982dec38688030d8733429ab5a8a2
Comment 3 Andrius Štikonas 2018-08-28 19:54:39 UTC
Git commit 7664b1f50a414232fa674940a4aec457518ffd7d by Andrius Štikonas, on behalf of Zdeněk Novák.
Committed on 28/08/2018 at 19:28.
Pushed by stikonas into branch '5.1'.

Formatting torrent ratio as floating point number - no scientific notation

'g' format uses exponential notation when numbers are too big or too small,
'f' keeps numbers in 0.00 format all the time.

Differential revision: https://phabricator.kde.org/D13971

M  +4    -4    ktorrent/trayicon.cpp
M  +1    -1    plugins/infowidget/peerviewmodel.cpp
M  +1    -1    plugins/infowidget/statustab.cpp

https://commits.kde.org/ktorrent/7664b1f50a414232fa674940a4aec457518ffd7d