Bug 395429 - [Feature Request] Number of instances on page search
Summary: [Feature Request] Number of instances on page search
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-15 13:38 UTC by kelseighn
Modified: 2020-02-15 14:32 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/falkon/0e25b116cb7d0c12871ae82331b3477b97f23549
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description kelseighn 2018-06-15 13:38:00 UTC 
When using CTRL+F to search for text on a web page, it would be very useful to have a count of how many instances of the entered text there were, if any. Falkon is the first browser I've tried that doesn't have that feature, and I believe it would help in day-to-day usage.
Comment 1 Juraj 2020-01-24 11:38:19 UTC 
Right, can be done with QtWebEngine 5.14.

See:
https://doc.qt.io/qt-5/qwebenginefindtextresult.html
Comment 2 Juraj 2020-02-15 14:32:46 UTC 
Git commit 0e25b116cb7d0c12871ae82331b3477b97f23549 by Juraj Oravec.
Committed on 15/02/2020 at 14:32.
Pushed by jurajo into branch 'master'.

SearchBar - Show number of matches found on page search

Summary: BUG: 395429

Test Plan: Open searchbar on webpage and type some text which is present on the page

Reviewers: #falkon, drosca

Reviewed By: #falkon, drosca

Subscribers: drosca, falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D27095

M  +19   -0    src/lib/webtab/searchtoolbar.cpp
M  +9    -0    src/lib/webtab/searchtoolbar.h
M  +7    -0    src/lib/webtab/searchtoolbar.ui

https://commits.kde.org/falkon/0e25b116cb7d0c12871ae82331b3477b97f23549