Created attachment 113226 [details] Screenshot of a problem There are two problems, both happen only with a Quick Brush and only when painting on a Transparency Mask (I didn't test other types of masks, but on a layer it works fine). 1) Rectangular areas of fully filled color appear in the middle of the stroke (you should paint quite a lot to get it) 2) When clearing the mask with Del key (between the strokes of Quick Brush), some areas of the layer have traces of the old content. Setting dirtyRect in KisToolUtils::clearImage() to image->bounds() magically solves the problem, so it means that the problem is somewhere in the extent calculation. Both problems happen somewhere in updates, because toggling wisibility of the mask solves both of them.
Git commit cf035350d949d47b711033c0aace91d960c8a685 by Dmitry Kazakov. Committed on 04/07/2018 at 09:50. Pushed by dkazakov into branch 'master'. Test for rectangular artifacts on transparency masks The problem itself is not solved yet. Only a test that can reproduce it in a stable way is implemented. The only things that I know right now is: 1) The problem is related to multithreading. It doesn't appear when the number of threads is limited to 1. 2) Artifacts appear only after clearing the transparency paint device. 3) Artifacts are neither present in the transparency mask paint device, nor in the projection of its parent layer. 4) Artifacts appear in the final image projection, right when the async merger calls layer->projectionPlane()-> ->apply(). 5) Changing dirtyRect in KisToolUtils::clearImage() to the entire image bounds doesn't help much. M +5 -0 libs/ui/tests/CMakeLists.txt A +134 -0 libs/ui/tests/KisPaintOnTransparencyMaskTest.cpp [License: UNKNOWN] * A +15 -0 libs/ui/tests/KisPaintOnTransparencyMaskTest.h [License: UNKNOWN] * A +- -- libs/ui/tests/data/testing_wet_circle.kpp M +5 -0 sdk/tests/stroke_testing_utils.cpp M +1 -0 sdk/tests/stroke_testing_utils.h The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://commits.kde.org/krita/cf035350d949d47b711033c0aace91d960c8a685
Git commit db2d098d56ef3aad73799f8e2c7ffaad575237ad by Dmitry Kazakov. Committed on 25/07/2018 at 16:50. Pushed by dkazakov into branch 'master'. Selection masks can paint outside internal selection This patch was originally intended to fix KisTransparencyMaskTest but it turned out it also fixes artifacts while painting/clearing on transparency masks. M +5 -0 libs/image/kis_transparency_mask.cc M +2 -0 libs/image/kis_transparency_mask.h https://commits.kde.org/krita/db2d098d56ef3aad73799f8e2c7ffaad575237ad