Bug 395230 - Render animation should probably default to the image fps for export fps.
Summary: Render animation should probably default to the image fps for export fps.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-10 23:42 UTC by wolthera
Modified: 2020-07-28 23:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2018-06-10 23:42:06 UTC
Not sure if this is a bug, but it seems Render Animation remembers its options which is a bit annoying when you had a 24frame animation that is rendered to 4fps.

Like, I can understand with it remembering the frame resize, but maybe not the fps...
Comment 1 Scott Petrovic 2018-06-18 21:59:32 UTC
it does remember it. We can ask Bollebib what his preference is. He is the main person that wanted these export options.  Maybe the FPS just shouldn't be remembered from last time.
Comment 2 Emmet O'Neill 2020-07-28 23:41:34 UTC
Git commit 8f78282e7b6d53b2760fbb4945910ccaf3cafc04 by Emmet O'Neill.
Committed on 28/07/2020 at 23:26.
Pushed by emmetoneill into branch 'master'.

Some "Render Animation" dialog settings init to document settings.

Start frame, end frame and frame rate will all be initialized to the
current values that the user has configured in the timeline settings
of the current document instead of the last used value.

M  +47   -57   libs/ui/animation/KisDlgAnimationRenderer.cpp
M  +1    -1    libs/ui/animation/KisDlgAnimationRenderer.h

https://invent.kde.org/graphics/krita/commit/8f78282e7b6d53b2760fbb4945910ccaf3cafc04
Comment 3 Emmet O'Neill 2020-07-28 23:44:23 UTC
Git commit cfa6d9f6156fc169664aa2ab87acc63a13164e2b by Emmet O'Neill.
Committed on 28/07/2020 at 23:44.
Pushed by emmetoneill into branch 'krita/4.3'.

Some "Render Animation" dialog settings init to document settings.

Start frame, end frame and frame rate will all be initialized to the
current values that the user has configured in the timeline settings
of the current document instead of the last used value.


(cherry picked from commit 8f78282e7b6d53b2760fbb4945910ccaf3cafc04)

M  +47   -57   libs/ui/animation/KisDlgAnimationRenderer.cpp
M  +1    -1    libs/ui/animation/KisDlgAnimationRenderer.h

https://invent.kde.org/graphics/krita/commit/cfa6d9f6156fc169664aa2ab87acc63a13164e2b