********* Start testing of WebViewTest ********* Config: Using QtTest library 5.11.0, Qt 5.11.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 8.1.0) PASS : WebViewTest::initTestCase() FAIL! : WebViewTest::loadSignalsChangePageTest() Compared values are not the same Actual (((loadFinishedSpy.count()))): 2 Expected (loadFinishedEmitCount) : 1 Loc: [/tmp/falkon-3.0.1/autotests/webviewtest.cpp(87)] PASS : WebViewTest::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 15276ms ********* Finished testing of WebViewTest ********* <end of output> Test time = 15.70 sec ---------------------------------------------------------- Test Failed. "falkon-webviewtest" end time: Jun 09 20:42 BST "falkon-webviewtest" time elapsed: 00:00:15 Further comments: If falkon has not yet been installed on a qt-5.11.0 system, 6 out of 10 of the tests fail. But after installation on at qt-5.11.0 system only this test fails. On a slightly older system, with qt-5.10 and falkon-3.0.0 already installed, all 10 tests passed. Diffing falkon-3.0.0 to 3.0.1 produced the following suspicious change (the change to 5.11 is not suspicious, the reversal of 2 : 1 to 1 : 2 is): index a21e693..40b0a57 100644 --- a/falkon-3.0.0/autotests/webviewtest.cpp +++ b/falkon-3.0.1/autotests/webviewtest.cpp @@ -82,7 +82,7 @@ void WebViewTest::loadSignalsChangePageTest() view.setPage(page2); // WebPage: Workaround for broken load started/finished signals in QtWebEngine 5.10 - const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.10.", 5) == 0 ? 2 : 1; + const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.11.", 5) == 0 ? 1 : 2; QTRY_COMPARE(loadFinishedSpy.count(), loadFinishedEmitCount); QCOMPARE(loadStartedSpy.count(), 0); Editing that line to const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.11.", 5) == 0 ? 2 : 1; all the tests pass on the 5.11.0 system.
Created attachment 113205 [details] Patch which works on both qt-5.10 and qt-5.11 Patch which works on both qt-5.10 and qt-5.11
Hmm, the bug system lost the comment I put in before attaching a patch. What I put in originally works on qt-5.11 but not on 5.10. I think the correct fix is to test for 5.10, not 5.11, with an operand of greater than or equal.
Ken can you please re-test with current Qt and Falkon and confirm if this is still an issue, if not we can close this bug report, thanks.
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
I think this was fixed by December 2018, my notes show that I stopped sedding that test when I was using qt-5.12.0.(In reply to Justin Zobel from comment #3) > Ken can you please re-test with current Qt and Falkon and confirm if this is > still an issue, if not we can close this bug report, thanks. I think this was fixed by December 2018, my notes show that I stopped sedding that test when I was using qt-5.12.0. With 3.1.0 plus fixes to include headers which moved in qt, all 11 tests pass. I could not see a link at github to get a current snapshot of falkon.
Thanks for the update Ken. Are you happy then for me to resolve this bug report?
(In reply to Justin Zobel from comment #6) > Thanks for the update Ken. > > Are you happy then for me to resolve this bug report? Sure.