Bug 395039 - Quick Open does not list any files
Summary: Quick Open does not list any files
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 18.04.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-05 06:57 UTC by mokush
Modified: 2018-06-14 08:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Kate demo showing empty Quick Open file list (258.80 KB, image/gif)
2018-06-05 06:57 UTC, mokush
Details
fix for bug (2.05 KB, patch)
2018-06-13 13:08 UTC, Sven Brauch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mokush 2018-06-05 06:57:20 UTC
Created attachment 113083 [details]
Kate demo showing empty Quick Open file list

In the Quick Open dialog (Alt+Ctrl+O by default), there are no files listed.

All files in the project are listed correctly in the Projects panel.

Regardless of the searched text, the file list stays empty.

I'm attaching a quick demo with a Git repo.
Comment 1 martchus 2018-06-11 10:51:11 UTC
I can confirm this issue. It also happens under other distros like Arch Linux and openSUSE Tumbleweed. Note that there are no error messages, also nothing via stdout/stderr.
Comment 2 Sven Brauch 2018-06-13 12:15:21 UTC
This is indeed broken, same here on Arch Linux :/
Quite a serious regression ...
Comment 3 Sven Brauch 2018-06-13 12:21:33 UTC
It's very strange though. The bug does not disappear again through downgrading either kate nor ktexteditor. Either it is in some other component, or caused by some broken config file.
Comment 4 martchus 2018-06-13 12:28:58 UTC
@Sven Maybe you haven't downgraded low enough? The version in the ticket is 18.0.4.1, but maybe the issue has already been present before.

Note that I haven't tried to downgrade myself but I likely try this evening. However, I have already tested with no configuration files present and could still reproduce the issue. So I suppose it is not a configuration-related issue.

And yes, I also consider this a serious regression. I'm wondering why nobody noticed this bug before releasing. This is one of Kate's most useful features compared to other text editors in my opinion.
Comment 5 Sven Brauch 2018-06-13 12:30:43 UTC
I downgraded to kate 17.08, which is the oldest kate I have in my cache, and it quite certainly worked there before ...
Comment 6 Martin Roukala 2018-06-13 12:50:47 UTC
Adding myself to the Cc because I also see the same problem on all my Arch boxes.
Comment 7 Sven Brauch 2018-06-13 12:52:01 UTC
The model seems populated properly, I can see that in Gammaray. Super strange issue.
Comment 8 Sven Brauch 2018-06-13 12:59:10 UTC
I think this has to do with the item model changes in Qt 5.11. It's either a regression in Qt, or more likely wrong usage of the API in kate which worked so far but is broken now.
Comment 9 Sven Brauch 2018-06-13 13:07:57 UTC
The attached patch fixes it, and makes more sense anyways. I do not understand why the old variant breaks though, ideas? What is certainly wrong is the mapToSource call, because it uses a different model, but otherwise?
Comment 10 Sven Brauch 2018-06-13 13:08:18 UTC
Created attachment 113248 [details]
fix for bug
Comment 11 Sven Brauch 2018-06-13 20:04:16 UTC
Git commit 291b68994d7c6176dbc1983c956e2bb7135559e0 by Sven Brauch.
Committed on 13/06/2018 at 20:03.
Pushed by brauch into branch 'Applications/18.04'.

Fix QuickOpen with Qt 5.11

It remains to be investigated whether this is a regression in Qt
itself, or misuse of the API on our side. There is at least one
misuse (the call to mapFromSource) which is wrong in the old version,
so this patch improves the situation in either case.

Differential Revision: https://phabricator.kde.org/D13517

M  +7    -14   kate/katequickopen.cpp

https://commits.kde.org/kate/291b68994d7c6176dbc1983c956e2bb7135559e0
Comment 12 martchus 2018-06-14 08:34:58 UTC
@sven Thanks, you patch made it already in the official Arch package!