Bug 394967 - Find dialog should not require a date range
Summary: Find dialog should not require a date range
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 5.8.1
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-02 20:24 UTC by jv
Modified: 2023-11-12 13:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jv 2018-06-02 20:24:00 UTC
When selecting Edit and then Find from the main menu the Search Calendar -- KOrganizer window pops up.  In that window even though you do not have the "Include Events within the specified date range" selected the date range filter is still being applied.  Since the default date ranges are From:"todays date" To:"one year from todays date" no historical events are produced by the search until you adjust the date range accordingly.
Comment 1 Allen Winter 2018-06-07 12:25:09 UTC
This may be a matter of not explaining better what this option is intended for.

Selecting the "Include Events within the specified date range" option means that events whose start and end datetimes are not fully contained within the date range will be excluded from the results.

if you want events from the past you will need to adjust the start search date.
Comment 2 jv 2018-06-11 15:22:22 UTC
I respectively disagree with your explanation.  First off if you do not select the date range field the system should not impose a date range on your search.  Secondly.  In Korganizer version 4.13.3 in Kubuntu 14.04 when you enter a string in the “Search for:” field and you do not select the “Include Events within the specified date range”, the system searches for all occurrences of that string in your calendar file.  I did verify this.  So this use to work as expected and somewhere since version 4.13.3 a change was made that broke this function.  I’m still calling this a bug.  Thanks.
Comment 3 Allen Winter 2018-06-11 21:47:23 UTC
I was simply trying to understand the situation.

So I think what you are saying is that you want to be able to turn-off searching in a date range. In the case where there is no date-range specified you want to search all incidences in your calendar.

is that right?
Comment 4 jv 2018-06-12 12:19:33 UTC
Yes.  That is what I am saying.  That is how it use to work in version 4.13.3.

Thanks.
Comment 5 gjditchfield 2021-09-07 01:57:46 UTC
Git commit 417ce07bf6dab73ae0e4c6fd10b47686e5ad52c4 by Glen Ditchfield, on behalf of Glen Ditchfield.
Committed on 07/09/2021 at 01:06.
Pushed by gditchfield into branch 'master'.

Clarify some labels and tooltip help in the Edit > Find... dialog

M  +1    -1    src/dialog/searchdialog.cpp
M  +28   -28   src/ui/searchdialog_base.ui

https://invent.kde.org/pim/korganizer/commit/417ce07bf6dab73ae0e4c6fd10b47686e5ad52c4
Comment 6 Daniel M 2023-10-25 14:08:50 UTC
Just wanted to chime in to say I largely concur with this. I frequency search for historical calendar entries and the default of searching one year into the future forces me to change this for most of my searches. If I had my choice, I think I'd default this to all dates or make the default configurable.  With modern SSDs, searching across all calendar entries will probably still be pretty fast.
Comment 7 Bug Janitor Service 2023-11-11 22:48:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/pim/korganizer/-/merge_requests/108
Comment 8 Daniel Vrátil 2023-11-12 13:10:09 UTC
Git commit 112eb224b554b8a31ac502193c1aacd537eb866e by Daniel Vrátil.
Committed on 12/11/2023 at 14:07.
Pushed by dvratil into branch 'master'.

Make the search date range limit optional

M  +35   -25   src/dialog/searchdialog.cpp
M  +1    -0    src/dialog/searchdialog.h
M  +30   -14   src/ui/searchdialog_base.ui

https://invent.kde.org/pim/korganizer/-/commit/112eb224b554b8a31ac502193c1aacd537eb866e