Bug 394960 - Kirigami.Theme.highlightColor changes depending on whether the window is selected
Summary: Kirigami.Theme.highlightColor changes depending on whether the window is sele...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.46.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-02 15:38 UTC by Matthew Trescott
Modified: 2019-03-05 17:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Screen recording of problem (533.53 KB, video/webm)
2018-06-02 15:38 UTC, Matthew Trescott
Details
Dolphin, sidebar selected (44.31 KB, image/png)
2018-08-06 15:25 UTC, Marco Martin
Details
Dolphin, text field selected (63.04 KB, image/png)
2018-08-06 15:25 UTC, Marco Martin
Details
Dolphin, config dialog sidebar selected (47.26 KB, image/png)
2018-08-06 15:26 UTC, Marco Martin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Trescott 2018-06-02 15:38:16 UTC
Created attachment 113015 [details]
Screen recording of problem

The attached recording shows the problem best.
Comment 1 Aleix Pol 2018-06-06 01:48:46 UTC
This does look a bit weird when it happens.

It happens as well with other colors, it's a bit weird as it's not something very common and it's definitely unexpected.
Could be a breeze issue. Or a feature.
Comment 2 Kai Uwe Broulik 2018-06-06 07:11:30 UTC
That's a feature, a window that doesn't have focus has desaturated colors. It's just that QtQuick Controls never really implemented it but it can definitely be observed with widget apps.
Comment 3 Matthew Trescott 2018-06-06 09:47:12 UTC
On widget applications, sure, but the only use I can think of is un-highlighting a button to indicate that it's not the default action. IMO text like in this case should remain the same, since there's no particular reason for it to change.
Comment 4 Marco Martin 2018-08-06 14:36:57 UTC
this is simply following global color settings

on systemsettings colors, "edit scheme" "inactive selection changes color"
Comment 5 Marco Martin 2018-08-06 14:40:23 UTC
(In reply to Matthew Trescott from comment #3)
> On widget applications, sure, but the only use I can think of is
> un-highlighting a button to indicate that it's not the default action. IMO
> text like in this case should remain the same, since there's no particular
> reason for it to change.

every list item in all qt application does this, like dolphin and whatnot.

I could make highlightcolor to stay the same and make change backgroundcolor of the selection set, so the selected text would stay the same, to 100% match qwidget applications
Comment 6 Marco Martin 2018-08-06 15:25:19 UTC
Created attachment 114331 [details]
Dolphin, sidebar selected
Comment 7 Marco Martin 2018-08-06 15:25:41 UTC
Created attachment 114332 [details]
Dolphin, text field selected
Comment 8 Marco Martin 2018-08-06 15:26:02 UTC
Created attachment 114333 [details]
Dolphin, config dialog sidebar selected
Comment 9 Marco Martin 2018-08-06 15:28:26 UTC
here screenshots of dolphin showing various pieces of the ui highlight color changing depending of active or inactive focus, which is the correct behavior.

if the whole behavior is into question, that would be a call to change the system default, which would be to be discussed with the VDG, but is not a kirigami issue
Comment 10 Matthew Trescott 2018-08-06 20:27:50 UTC
Those are all interactive widgets, not non-interactive text. Imagine if the word "Startup" in your last screenshot turned green when Dolphin's config windows was un-focused. It wouldn't make any sense.
Comment 11 Matthew Trescott 2018-08-06 20:34:46 UTC
Sorry, I realized that we're talking about different things. I'm talking specifically about the word "Graphics" in the header turning black when the window is defocused. I don't have any problem with the interactive widgets switching to a lighter shade of blue.
Comment 12 Christoph Feck 2018-08-30 21:44:11 UTC
Could you please check if disabling the option "Use different colors for inactive selections" in the systemsettings color scheme editor makes a difference?
Comment 13 Matthew Trescott 2018-08-30 21:52:00 UTC
I can't test this anymore because discover changed how the category titles are displayed.
Comment 14 Marco Martin 2019-03-05 17:19:51 UTC
Git commit 8ea2fd7f571dd4de555579c769dddc6be11217e7 by Marco Martin.
Committed on 05/03/2019 at 17:19.
Pushed by mart into branch 'master'.

text on images always need to be white

M  +2    -1    src/controls/ItemViewHeader.qml

https://commits.kde.org/kirigami/8ea2fd7f571dd4de555579c769dddc6be11217e7