Bug 394857 - Reports do not graph operations by week correctly
Summary: Reports do not graph operations by week correctly
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-30 11:06 UTC by dberg918
Modified: 2018-05-30 19:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dberg918 2018-05-30 11:06:10 UTC
I am currently looking at a graph of my spending by week in the month of May. I expect spending for Sunday, May 27th, to appear in the column for Week 22 since Sunday is the first day of the week. However, operations on the 27th appear in the column for Week 21, the previous week.

I am running Skrooge 2.12 in GNOME 3.28, so I don't have access to KDE system settings to check if my calendar settings are off, but I'm pretty sure the default behavior is for Sunday to be considered the first day of the week.
Comment 1 Stephane MANKOWSKI 2018-05-30 19:00:15 UTC
Git commit ec90f21cfd66a0c010f6d963a414650c29ee1a3c by Stephane MANKOWSKI.
Committed on 30/05/2018 at 18:59.
Pushed by smankowski into branch 'master'.

Reports do not graph operations by week correctly

M  +1    -0    CHANGELOG
M  +4    -3    skgbankmodeler/skgdocumentbank.cpp

https://commits.kde.org/skrooge/ec90f21cfd66a0c010f6d963a414650c29ee1a3c
Comment 2 Stephane MANKOWSKI 2018-05-30 19:01:38 UTC
Hi,
The correction should work (tested on sqlite) but I am not able to test it from Skrooge.
If you are able to build Skrooge from git version, this could help.
Regards.