Bug 394832 - JJ: "CTRL+G" does not work if the last selected layer is a filter.
Summary: JJ: "CTRL+G" does not work if the last selected layer is a filter.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: git master (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-05-29 14:16 UTC by mvowada
Modified: 2018-06-05 08:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2018-05-29 14:16:41 UTC
On Ubuntu Unity - Krita 4.1.0-pre-alpha (git dac4dc7)

Steps:

    1) Add a "Transparency Mask" to the lowest layer you want to group
    2) click the topmost layer in the docker 
    3) SHIFT + click the T. Mask
    4) CTRL + G

Actual Results: nothing happens.
Expected Results: group layers.
Comment 1 Halla Rempt 2018-05-29 14:18:59 UTC
I can confirm this: what happens is that Krita sees that the current node is a mask, and thinks that the group layer action cannot be performed. If you'd select the mask, then shift select to the top layer, the action works.
Comment 2 Halla Rempt 2018-06-05 08:13:42 UTC
Git commit ae410a3ddc36ccbe8d28880176ec39827ede48a0 by Boudewijn Rempt.
Committed on 05/06/2018 at 08:13.
Pushed by rempt into branch 'krita/4.0'.

Allow creating a group if the current node is a mask

M  +1    -1    krita/krita.action
M  +1    -2    libs/image/kis_layer_utils.cpp

https://commits.kde.org/krita/ae410a3ddc36ccbe8d28880176ec39827ede48a0
Comment 3 Halla Rempt 2018-06-05 08:13:48 UTC
Git commit 6d769df9fec56f5f7c78d43fbb4444b2d9742027 by Boudewijn Rempt.
Committed on 05/06/2018 at 08:13.
Pushed by rempt into branch 'master'.

Allow creating a group if the current node is a mask
(cherry picked from commit ae410a3ddc36ccbe8d28880176ec39827ede48a0)

M  +1    -1    krita/krita.action
M  +1    -2    libs/image/kis_layer_utils.cpp

https://commits.kde.org/krita/6d769df9fec56f5f7c78d43fbb4444b2d9742027