Created attachment 112913 [details] bluetooth adapter not visible warning Hello, When configuring bluetooth I noticed that KDE create a big orange banner with a `Fix it` button when the bluetooth adapter is set to `Hidden`. In my opinion such banner is useful as it can help figure out why your bluetooth is not working. But it's too big and flashy, there are lots of reason to not set the adapter as `Always visible` and the `Fix it` button imply that something is wrongly setup. Regards
I think it's fine. Visual preferences can't please everyone. Tagging VDG for comment before I close it.
In fact, we just improved the look of the inline messages a few weeks ago (https://phabricator.kde.org/D12508), and that change will be in Frameworks 5.47. I think it's safe to close this since we've already essentially done what the OP wanted.
We can probably improve the button text to better reflect the exact issue though, and avoid implying the existence of a problem (from the user's perspective) when none exists. Here's a patch for that: https://phabricator.kde.org/D13346
Awesome, that's exactly what I had in mind.
Git commit c7f72367599b8248e69f194243ab95fc315ce841 by Nathaniel Graham. Committed on 05/06/2018 at 11:11. Pushed by ngraham into branch 'master'. Use more contextual strings for some button labels Summary: Every Bluetooth error's "fix this error" button's text is "Fix it". However, some issues are not actually problems //per se// from the user's perspective, so the text can imply the existence of a problem where none exists. In the case where the Bluetooth adapter is powered off or disabled, display a more contextually appropriate string instead ("Turn On" and "Enable", respectively) FIXED-IN: 5.14 Test Plan: {F5890529} Reviewers: #plasma, #vdg, drosca Reviewed By: drosca Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D13346 M +2 -2 src/kcmodule/common/systemcheck.cpp M +5 -1 src/sendfile/discoverwidget.cpp https://commits.kde.org/bluedevil/c7f72367599b8248e69f194243ab95fc315ce841
Is the addition of a 'dismiss' button/cross an idea? The 'not visible' warning message (which imo should be a info message) is eye catching and causes the Bluetooth Devices menu to have scroll bar. Being able to dismiss the message should be an option. Should I create a separate bug to discuss this?