Bug 394673 - icon in system tray offers plasma-browser-integration even if it's already installed and working
Summary: icon in system tray offers plasma-browser-integration even if it's already in...
Status: RESOLVED WORKSFORME
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-25 15:08 UTC by Patrick Silva
Modified: 2018-06-01 10:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (324.48 KB, image/png)
2018-05-25 15:08 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-05-25 15:08:27 UTC
Created attachment 112867 [details]
screenshot

Both plasma-browser-integration package and extension for Firefox are installed on my system and system tray shows the icon "Get plasma browser integration" anyway.
Comment 1 Kai Uwe Broulik 2018-05-28 14:41:03 UTC
Is a plasma-browser-integration process running and does the extension actually work?
Comment 2 Patrick Silva 2018-05-28 20:15:05 UTC
yes, plasma-browser-integration process is running and Firefox extension works. I can search for tabs using krunner and notifications applet shows download progress in system tray.
Comment 3 David Edmundson 2018-05-29 15:58:48 UTC
was the extension installed before you started firefox and then saw this notification?
Comment 4 Patrick Silva 2018-05-29 19:21:19 UTC
Every time I open Firefox notification/icon of plasma borwser integration appears in system tray. The icon remains visible in system tray even after I close Firefox.
Comment 5 Kai Uwe Broulik 2018-05-30 08:37:52 UTC
Every time? That's odd.

Can you check what "shownCount" is in [PlasmaBrowserIntegration] of ~/.config/kded5rc and whether it changes as you start Firefox.

Does your Firefox take awfully long (> 10 seconds) to start?
Comment 6 Kai Uwe Broulik 2018-05-30 08:39:17 UTC
Can you also check with qdbusviewer what the service name of it is, org.kde.plasma.browser_integration. I think you might be running multiple browser instances and then it appends PID and our check fails.

I'll fix two things:
* Check for any DBus service starting with said name instead of complete match
* Watch for service unregistration and hide the Tray icon when that happens
Comment 7 Kai Uwe Broulik 2018-05-30 08:41:16 UTC
> Check for any DBus service starting with said name instead of complete match

Though it will only do that if another service with that name is already registered at which point we'll find one, so this shouldn't be neccessary
Comment 8 Patrick Silva 2018-05-30 15:16:20 UTC
Well, after I install some updates this morning the problem disappeared from my Arch Linux.
Comment 9 Kai Uwe Broulik 2018-06-01 08:00:26 UTC
Thanks for the update, closing then. Will still implement the monitoring, though.
Comment 10 Kai Uwe Broulik 2018-06-01 10:45:09 UTC
Git commit 4f5eeec505e8a401331db0b5a3e17416f63590b0 by Kai Uwe Broulik.
Committed on 01/06/2018 at 10:44.
Pushed by broulik into branch 'Plasma/5.13'.

[Installation Reminder] Watch for service registration and hide

In case the browser takes forever to start or user installs the extension manually without clicking the SNI.

Differential Revision: https://phabricator.kde.org/D13210

M  +14   -1    reminder/browserintegrationreminder.cpp
M  +1    -0    reminder/browserintegrationreminder.h

https://commits.kde.org/plasma-browser-integration/4f5eeec505e8a401331db0b5a3e17416f63590b0