Bug 394621 - support strikethrough annotations
Summary: support strikethrough annotations
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-23 15:55 UTC by Kevin Burton
Modified: 2018-05-24 04:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Burton 2018-05-23 15:55:31 UTC
I'd like to request support for strikethrough annotations.

They are part of the PDF annotation spec and very useful.

Here's an example.  

https://imgur.com/V3I2flI
Comment 1 Burkhard Lück 2018-05-23 17:45:12 UTC
https://phabricator.kde.org/D13072
Comment 2 Albert Astals Cid 2018-05-23 18:35:11 UTC
This is supported since ages.
Comment 3 Kevin Burton 2018-05-23 19:45:01 UTC
I wish I was wrong here but not on my 1.33 and not on unstable okular either.  

Here's what I have:


https://imgur.com/a/UR9w77J


Adding a new annotation shows less than the screenshot above.


Am I missing something?
Comment 4 Albert Astals Cid 2018-05-23 20:23:15 UTC
Yes https://i.imgur.com/bR5hJW4.png
Comment 5 Kevin Burton 2018-05-23 20:26:44 UTC
Wow.. Fascinating.  Can you screenshot how you did that? or take a video?

That's definitely not on my machine.  I don't even have 'strike out' as one of the options in type when I edit an existing one.

I have TWO 'pop up note' options though. Which is weird.

Thanks for the help here!
Comment 6 Kevin Burton 2018-05-23 20:28:08 UTC
I wonder if there some IFDEF issue here with poppler or something not having support for those annotation types.
Comment 7 Kevin Burton 2018-05-23 20:29:47 UTC
OK.. I DO have polygon. Just not rectangle.

Rectangle is important:

1. they're easy resize.

2. I can resize just the left, right, top , or bottom, or I can pick the corner to resize.  

3. Drawing a rectangle around a figure is a lot easier than drawing a polygon to keep the sides even.
Comment 8 Albert Astals Cid 2018-05-23 21:24:48 UTC
you commented on the wrong bug, this is about strikethrough.
Comment 9 Albert Astals Cid 2018-05-23 21:33:47 UTC
(In reply to Kevin Burton from comment #5)
> Wow.. Fascinating.  Can you screenshot how you did that? or take a video?

https://www.youtube.com/watch?v=5BBwYbacTMQ

> I wonder if there some IFDEF issue here with poppler or something not having support for those annotation types.

Annotations don't really depend on poppler, they are abstracted on the okular core level, as you can see the video is on a txt file.
Comment 10 Kevin Burton 2018-05-23 21:37:18 UTC
ok.. so then maybe this bug is more about the fact that , at least on 1 machine, strike through isn't an option.
Comment 11 Albert Astals Cid 2018-05-23 21:46:17 UTC
(In reply to Kevin Burton from comment #10)
> ok.. so then maybe this bug is more about the fact that , at least on 1
> machine, strike through isn't an option.

That's just not possible, see
https://cgit.kde.org/okular.git/tree/ui/annotationwidgets.cpp#n539
the four styles are added unconditionally.
Comment 12 Kevin Burton 2018-05-24 02:18:30 UTC
Thx.. I'm going to post to the forum and see if other users have a similar issue. I mean they literally don't show up on my machine so something here is weird.
Comment 13 Oliver Sander 2018-05-24 04:48:51 UTC
I justed tried, and I do indeed have the strikethrough option.