Bug 394512 - Translation count columns should be right-aligned
Summary: Translation count columns should be right-aligned
Status: RESOLVED FIXED
Alias: None
Product: lokalize
Classification: Applications
Component: project management (show other bugs)
Version: 2.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Karl Ove Hufthammer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-21 09:50 UTC by Karl Ove Hufthammer
Modified: 2018-05-28 20:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 18.04.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2018-05-21 09:50:13 UTC
The four numeric columns (Total, Translated, Fuzzy, Not translated) should be right-aligned, so that digits with the same significance (units, tens, hundreds) are stacked vertically. They are currently left-aligned.
Comment 1 Karl Ove Hufthammer 2018-05-24 18:18:48 UTC
Proposed patch available at https://phabricator.kde.org/D13098
Comment 2 Karl Ove Hufthammer 2018-05-28 20:16:13 UTC
Git commit c97fa50b0b31c905cfb7a2bfacb679e747c92547 by Karl Ove Hufthammer.
Committed on 28/05/2018 at 20:16.
Pushed by huftis into branch 'Applications/18.04'.

Right-align all translation count columns in Project Overview

Summary:
Before this patch, all columns in the Project Overview tab
were left-aligned. The patch changes the alignment for the
four translation count columns (‘Total’, ‘Translated’, ‘Not ready’
and ‘Untranslated’) to right alignment.

The effect is that the counts are easier to compare across files,
since the unit, ‘tens’, ‘hundreds’ etc. parts of the numbers are
now aligned.
FIXED-IN: 18.04.2

Test Plan:
  # Open a localisation project
  # Observe that four translation count columns (‘Total’, ‘Translated’, ‘Not ready’ and ‘Untranslated’) are now right-aligned, while they used to be left-aligned.
  # Observe that no other columns change alignment.

Reviewers: ltoscano, shaforostoff, sharvey, ngraham, aacid, #localization

Reviewed By: aacid, #localization

Subscribers: oysteins, kde-i18n-doc

Tags: #localization

Differential Revision: https://phabricator.kde.org/D13098

M  +31   -14   src/project/projectmodel.cpp

https://commits.kde.org/lokalize/c97fa50b0b31c905cfb7a2bfacb679e747c92547