Hi, This is a bug I demoed at the KritaSprint 2018 in front of Dmitry. It affect the brush preset docker and drag and drop gesture over it. To reproduce: ============= 1. On a canvas with random painted stroke: 2. Select the "airbrush preset" but keep the stylus/mouse button pressed, then drag to the neighbor brush preset icon (the soft eraser), release the mouse click 3. paint Result: ======= While having the soft eraser selected on the GUI, the settings loaded are the one of the airbrush preset. This is reproducible with mouse as well, and for any brush preset icons with dragging&dropping to the neighbor icons. Expected: ========= Get the GUI and the settings in sync: what is visually selected = setting you paint with.
Git commit a83ef86d9805867e82e21f4e502ae9c31fc7f1e4 by Dmitry Kazakov. Committed on 22/06/2018 at 15:25. Pushed by dkazakov into branch 'master'. Fix activation of a brush preset when it is selected by a dragging action NOTE: please let this patch to be tested for a couple of weeks before merging it into 4.1. KoResourceItemChooser::activated() we should check the actual resource that is passed to a function instead of requesting the currently selected, because it might still be not updated (when calling this function in selectionChanged() callback). M +15 -2 libs/widgets/KoResourceItemChooser.cpp https://commits.kde.org/krita/a83ef86d9805867e82e21f4e502ae9c31fc7f1e4
Git commit 16d83d74030a1522fbf115be6af82896b1084248 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 25/06/2018 at 07:57. Pushed by rempt into branch 'krita/4.1'. Fix activation of a brush preset when it is selected by a dragging action NOTE: please let this patch to be tested for a couple of weeks before merging it into 4.1. KoResourceItemChooser::activated() we should check the actual resource that is passed to a function instead of requesting the currently selected, because it might still be not updated (when calling this function in selectionChanged() callback). M +15 -2 libs/widgets/KoResourceItemChooser.cpp https://commits.kde.org/krita/16d83d74030a1522fbf115be6af82896b1084248
Git commit 213584df51254e4cf2f91b56ec4aee8b49e0ca5c by Andrey Kamakin, on behalf of Dmitry Kazakov. Committed on 26/06/2018 at 14:18. Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'. Fix activation of a brush preset when it is selected by a dragging action NOTE: please let this patch to be tested for a couple of weeks before merging it into 4.1. KoResourceItemChooser::activated() we should check the actual resource that is passed to a function instead of requesting the currently selected, because it might still be not updated (when calling this function in selectionChanged() callback). M +15 -2 libs/widgets/KoResourceItemChooser.cpp https://commits.kde.org/krita/213584df51254e4cf2f91b56ec4aee8b49e0ca5c