Bug 394362 - Add "Apply" button to Special Window / Application Settings
Summary: Add "Apply" button to Special Window / Application Settings
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: rules (show other bugs)
Version: 5.12.5
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-17 09:15 UTC by Daniel
Modified: 2018-06-05 04:32 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2018-05-17 09:15:02 UTC
Sometimes I will open up the Special Window or Application settings window to change something, but there are so many options, some dangerous too!

Trying out some of the settings, I decided to change some but pressing the "OK" button closes and saves the changes which take effect immediately. I've been stuck and still am stuck for a very long time trying to restore my title bar for Firefox, which I turned off. I can't seem to find anywhere in System Settings which has a list of changes which can be reverted. There's a Window Management -> Window Rules, but it's empty. :-(

So I implore you from a usability and user experience perspective to please add an "Apply" button to both of these windows, so before clicking "OK" I can preview the changes and revert any changes should I not like them.

Thank you in advance :-)
Comment 1 Martin Flöser 2018-05-17 15:35:51 UTC
You don't have decorations in Firefox because Firefox switched to client side decorations. Please report to Mozilla.
Comment 2 Christoph Feck 2018-05-17 19:57:03 UTC
In Firefox, visit about:config and change "browser.tabs.drawInTitlebar" setting.
Comment 3 Christoph Feck 2018-05-17 19:57:50 UTC
(And additionally report to Firefox developers that their new default is annoying :)

See https://www.reddit.com/r/kde/comments/8k326i/how_to_get_kwin_back_on_firefox_60/
Comment 4 Daniel 2018-05-17 22:14:50 UTC
I did have decorations. I am still running Firefox 59 (not 60). I removed those window decorations by right-clicking the title bar, selecting "More Actions", and selecting "Special Application Settings". In that dialog, I went to "Appearance & Fixes", selected the "No titlebar and frame" option, in the dropdown selected "Force" and in the radio button selected "Yes", I then pressed "OK" to see the changes, but it closed the window and applied that change immediately, with no way to get it back.

This applies to every other application and window where these changes can be made to. I am simply asking for a way to be able to preview the changes (a la an "Apply" button) without closing the window, so I can see changes and:
(a) Not be stuck,
(b) If I don't like the changes (and didn't remove the title bar), I don't have to go through the lengthy process to open the settings window again: right-click titlebar> More Actions> Special (Window|Application) Settings...

Thanks :-)
Comment 5 Martin Flöser 2018-05-18 04:18:26 UTC
You can always get back there by using special window settings again. Use alt+f3 to invoke the menu
Comment 6 Daniel 2018-05-18 04:21:26 UTC
(In reply to Martin Flöser from comment #5)
> You can always get back there by using special window settings again. Use
> alt+f3 to invoke the menu

Thanks. :-) I did not know that.

I still think an "Apply" button that does not close the window is still necessary, though, as that is a really esoteric shortcut.
Comment 7 Daniel 2018-05-23 08:36:34 UTC
Is "INVALID" still appropriate for this bug / feature request, given that it applies to ALL windows that KWin manages, and not a Firefox problem which people misread the OP to be?
Comment 8 Daniel 2018-06-04 12:22:18 UTC
I reopened the bug because "INVALID" isn't appropriate, given the people replying assumed this was a GTK/Firefox CSD issue when it is in fact not.
Comment 9 Martin Flöser 2018-06-04 15:00:03 UTC
In that case I change to feature request and I'm sorry to say that this is not worth the development effort. In fact it's technically not possible to provide an apply button as some rule types are one shots.
Comment 10 Daniel 2018-06-05 00:47:08 UTC
(In reply to Martin Flöser from comment #9)
> In that case I change to feature request and I'm sorry to say that this is
> not worth the development effort. In fact it's technically not possible to
> provide an apply button as some rule types are one shots.

Can't you just copy the code for the close button, but leave out the `window.close()` (or whatever) part? That's all I'm asking for, leave the window there and open.
Comment 11 Martin Flöser 2018-06-05 04:32:37 UTC
If it were that simple... The rule you created might be single shot. On apply KWin would apply it and delete it.