Bug 394332 - Albums with the same name get merged
Summary: Albums with the same name get merged
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-16 14:58 UTC by Diego Gangl
Modified: 2018-06-24 11:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Gangl 2018-05-16 14:58:08 UTC
When you have two or more albums with the same but from different artists they end up getting "merged" in the DB. I noticed this because I have multiple "Greatest Hits" albums that ended up merged in a single album with the artist set to "Various Artists".

Version: Elisa from master
Comment 1 Matthieu Gallien 2018-05-16 15:07:57 UTC
I will investigate. Could you check their tags and post a list of them here. I am only interested about their presence and not their value.
Comment 2 Diego Gangl 2018-05-16 17:30:36 UTC
Here's a couple of them (using ffprobe):

-------------------------------------------------------------------------------
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '01 Gimme All Your Lovin'.m4a':
  Metadata:
    major_brand     : M4A 
    minor_version   : 0
    compatible_brands: M4A mp42isom
    creation_time   : 2006-11-30 11:21:03
    track           : 1/18
    disc            : 1/1
    genre           : Rock
    album           : Greatest Hits
    album_artist    : ZZ Top
    artist          : ZZ Top
    composer        : Beard/Gibbons/Hill

-------------------------------------------------------------------------------

Input #0, mp3, from 'Mystify.mp3':
  Metadata:
    replaygain_track_gain: -0.00 dB
    replaygain_track_peak: 0.428690
    title           : Mystify
    album           : Greatest Hits
    artist          : INXS
  Duration: 00:03:16.52, start: 0.025056, bitrate: 218 kb/s

-------------------------------------------------------------------------------

Input #0, mp3, from 'Another One Bites The Dust.mp3':
  Metadata:
    replaygain_track_gain: +1.06 dB
    replaygain_track_peak: 0.722210
    title           : Another One Bites The Dust
    album           : Greatest Hits
    artist          : Queen
  Duration: 00:03:37.07, start: 0.000000, bitrate: 134 kb/s

-------------------------------------------------------------------------------

Input #0, mp3, from '01 American Girl.mp3':
  Metadata:
    track           : 1
    replaygain_track_gain: -0.87 dB
    replaygain_track_peak: 0.499961
    title           : American Girl
    artist          : Tom Petty & The Heartbreakers
    album           : Greatest Hits
    genre           : Rock
    date            : 1993
  Duration: 00:03:32.88, start: 0.000000, bitrate: 321 kb/s


Is there a quick way to list them all? There's about 5-6 albums mixed in.
Comment 3 Matthieu Gallien 2018-05-16 18:13:29 UTC
Thanks for the information.

I believe someone already suggested to use the path to help solve this kind of problem. I will try something like that.
Comment 4 Matthieu Gallien 2018-06-04 17:21:35 UTC
I have started to work on this: https://phabricator.kde.org/T8953
Comment 5 Matthieu Gallien 2018-06-24 11:39:33 UTC
Git commit c39fb6c703f1421ca1c2d2d449d87ff5fc3af4f9 by Matthieu Gallien.
Committed on 24/06/2018 at 11:39.
Pushed by mgallien into branch '0.2'.

unmerge albums by using the paths of their tracks

Summary:
unmerge albums by using the paths of their tracks

fix typo in DatabaseInterface::getDuplicateTrackIdFromTitleAlbumTrackDiscNumber

fix some problems with database due to errors in foreign keys management

duplicate albums if they look like the same but have a different path
where there tracks are located

fix mediaplaylisttest.cpp automatic tests after fixing bugs in the db

Test Plan: tests are OK

Reviewers: astippich, januz

Reviewed By: astippich

Maniphest Tasks: T8953

Differential Revision: https://phabricator.kde.org/D13423

M  +320  -5    autotests/databaseinterfacetest.cpp
M  +8    -8    autotests/mediaplaylisttest.cpp
M  +224  -35   src/databaseinterface.cpp
M  +16   -4    src/databaseinterface.h
M  +12   -0    src/musicalbum.cpp
M  +4    -0    src/musicalbum.h

https://commits.kde.org/elisa/c39fb6c703f1421ca1c2d2d449d87ff5fc3af4f9